You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "innovark37 (via GitHub)" <gi...@apache.org> on 2026/01/20 15:35:11 UTC
[PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
innovark37 opened a new pull request, #37287:
URL: https://github.com/apache/superset/pull/37287
### SUMMARY
This PR fixes an issue where SVG images in EmptyState components were being cropped at the edges, causing visual clipping and incomplete display of illustrations.
#### Affected Images:
- `empty.svg`
- `empty-dashboard.svg`
- `star-circle.svg`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
<img width="247" height="319" alt="image" src="https://github.com/user-attachments/assets/f2e96d59-75b4-47a4-8882-58a2b7bf8b20" /> <img width="264" height="314" alt="{4D3D2EFB-198B-4FC0-9A4B-43488056B4B6}" src="https://github.com/user-attachments/assets/802b56c5-5f56-46c2-ae88-d905823d243c" /> <img width="248" height="311" alt="{401F604D-A21F-4118-A8A4-C1BDB824705A}" src="https://github.com/user-attachments/assets/5b728f68-0ac5-4413-9b09-38e899a825b8" />
AFTER
<img width="241" height="308" alt="image" src="https://github.com/user-attachments/assets/7404f14f-5716-48d3-bd02-1666844480f1" /> <img width="240" height="312" alt="image" src="https://github.com/user-attachments/assets/44950320-bc56-4f86-b471-7533c2fe03bd" /> <img width="263" height="316" alt="image" src="https://github.com/user-attachments/assets/1f4381e5-dc2e-42a5-9900-0df2e9471630" />
### TESTING INSTRUCTIONS
Before starting, ensure:
- No dashboards exist in the system
- No charts exist in the system
- No saved queries exist in the system
#### Test Steps
1. Test "Empty Dashboard" image (`empty-dashboard.svg`)
1.1. Navigate to Welcome page (/)
1.2. Locate the "Dashboards" section
1.3. Click the "Mine" tab
1.4. Verify the empty state illustration
1.5. Click the "All" tab
1.6. Verify the empty state illustration
2. Test "Star" image for Favorites (`star-circle.svg`)
2.1. Navigate to Welcome page (/)
2.2. Locate the "Dashboards" section
2.3. Click the "Favorite" tab
2.4. Verify the star illustration
2.5. Repeat in "Charts" section, "Favorite" tab
3. Test "Empty" image (`empty.svg`)
3.1. Navigate to Welcome page (/)
3.2. Locate the "Saved Queries" section
3.3. Click the "Mine" tab
3.4. Verify the empty state illustration
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3780612632
@kasiazjc if you want to review once showtime is up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3773499839
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3773516266
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | fe6bb538ad55eee036e8b7b87915ba97ee953a1f |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/696fa0b01b125e00081d8162 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-37287--superset-docs-preview.netlify.app](https://deploy-preview-37287--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37287--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3773496503
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #37287:
URL: https://github.com/apache/superset/pull/37287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "innovark37 (via GitHub)" <gi...@apache.org>.
innovark37 commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-4038412725
@sadpandajoe
Hi! This PR is still open and I'd love to move it forward. If there are any concerns or changes needed, please let me know and I'll be happy to address them. Thanks for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-4211199603
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/37287?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.37%. Comparing base ([`c496415`](https://app.codecov.io/gh/apache/superset/commit/c49641538d5e388ea684d050a4ba6a6422d1d02d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4ef4ae9`](https://app.codecov.io/gh/apache/superset/commit/4ef4ae92a017e1dadb7a43b7b265aee6a29b17e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #37287 +/- ##
==========================================
- Coverage 64.38% 64.37% -0.01%
==========================================
Files 2550 2550
Lines 132141 132124 -17
Branches 30658 30657 -1
==========================================
- Hits 85074 85051 -23
- Misses 45584 45596 +12
+ Partials 1483 1477 -6
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/37287/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/37287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.91% <ΓΈ> (ΓΈ)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/37287?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3780617814
πͺ [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/21221783274) for [87ff7b9](https://github.com/apache/superset/commit/87ff7b9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3780690719
πͺ [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/21221783274) for [87ff7b9](https://github.com/apache/superset/commit/87ff7b9)
β’ **Environment:** http://35.93.162.233:8080 (admin/admin)
β’ **Lifetime:** 48h auto-cleanup
β’ **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(EmptyState): prevent SVG cropping in empty state images [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37287:
URL: https://github.com/apache/superset/pull/37287#issuecomment-3773496100
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! π
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) Β·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) Β·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org