You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Ted Yu <yu...@gmail.com> on 2015/12/30 06:36:05 UTC
IndentationCheck of checkstyle
Hi,
I noticed that there are a lot of checkstyle warnings in the following form:
<error line="1784" severity="error" message="'block' child have
incorrect indentation level 8, expected level should be 10."
source="com.puppycrawl.tools.checkstyle.
checks.indentation.IndentationCheck"/>
To my knowledge, we use two spaces for each tab. Not sure why all of a
sudden we have so many IndentationCheck warnings:
grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
3133 52645 678294
If there is no objection, I would create a JIRA and relax IndentationCheck
warning.
Cheers
Re: IndentationCheck of checkstyle
Posted by Ted Yu <yu...@gmail.com>.
Right.
Pardon my carelessness.
> On Dec 29, 2015, at 9:58 PM, Reynold Xin <rx...@databricks.com> wrote:
>
> OK to close the loop - this thread has nothing to do with Spark?
>
>
>> On Tue, Dec 29, 2015 at 9:55 PM, Ted Yu <yu...@gmail.com> wrote:
>> Oops, wrong list :-)
>>
>>> On Dec 29, 2015, at 9:48 PM, Reynold Xin <rx...@databricks.com> wrote:
>>>
>>> +Herman
>>>
>>> Is this coming from the newly merged Hive parser?
>>>
>>>
>>>
>>>> On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang <al...@126.com> wrote:
>>>>
>>>>
>>>> format issue I think, go ahead
>>>>
>>>>
>>>>
>>>>
>>>> At 2015-12-30 13:36:05, "Ted Yu" <yu...@gmail.com> wrote:
>>>> Hi,
>>>> I noticed that there are a lot of checkstyle warnings in the following form:
>>>>
>>>> <error line="1784" severity="error" message="'block' child have incorrect indentation level 8, expected level should be 10." source="com.puppycrawl.tools.checkstyle. checks.indentation.IndentationCheck"/>
>>>>
>>>> To my knowledge, we use two spaces for each tab. Not sure why all of a sudden we have so many IndentationCheck warnings:
>>>>
>>>> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
>>>> 3133 52645 678294
>>>>
>>>> If there is no objection, I would create a JIRA and relax IndentationCheck warning.
>>>>
>>>> Cheers
>
Re: IndentationCheck of checkstyle
Posted by Reynold Xin <rx...@databricks.com>.
OK to close the loop - this thread has nothing to do with Spark?
On Tue, Dec 29, 2015 at 9:55 PM, Ted Yu <yu...@gmail.com> wrote:
> Oops, wrong list :-)
>
> On Dec 29, 2015, at 9:48 PM, Reynold Xin <rx...@databricks.com> wrote:
>
> +Herman
>
> Is this coming from the newly merged Hive parser?
>
>
>
> On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang <al...@126.com>
> wrote:
>
>>
>>
>> format issue I think, go ahead
>>
>>
>>
>>
>> At 2015-12-30 13:36:05, "Ted Yu" <yu...@gmail.com> wrote:
>>
>> Hi,
>> I noticed that there are a lot of checkstyle warnings in the following
>> form:
>>
>> <error line="1784" severity="error" message="'block' child have
>> incorrect indentation level 8, expected level should be 10."
>> source="com.puppycrawl.tools.checkstyle.
>> checks.indentation.IndentationCheck"/>
>>
>> To my knowledge, we use two spaces for each tab. Not sure why all of a
>> sudden we have so many IndentationCheck warnings:
>>
>> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
>> 3133 52645 678294
>>
>> If there is no objection, I would create a JIRA and
>> relax IndentationCheck warning.
>>
>> Cheers
>>
>>
>>
>>
>>
>
>
Re: IndentationCheck of checkstyle
Posted by Ted Yu <yu...@gmail.com>.
Oops, wrong list :-)
> On Dec 29, 2015, at 9:48 PM, Reynold Xin <rx...@databricks.com> wrote:
>
> +Herman
>
> Is this coming from the newly merged Hive parser?
>
>
>
>> On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang <al...@126.com> wrote:
>>
>>
>> format issue I think, go ahead
>>
>>
>>
>>
>> At 2015-12-30 13:36:05, "Ted Yu" <yu...@gmail.com> wrote:
>> Hi,
>> I noticed that there are a lot of checkstyle warnings in the following form:
>>
>> <error line="1784" severity="error" message="'block' child have incorrect indentation level 8, expected level should be 10." source="com.puppycrawl.tools.checkstyle. checks.indentation.IndentationCheck"/>
>>
>> To my knowledge, we use two spaces for each tab. Not sure why all of a sudden we have so many IndentationCheck warnings:
>>
>> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
>> 3133 52645 678294
>>
>> If there is no objection, I would create a JIRA and relax IndentationCheck warning.
>>
>> Cheers
>
Re: IndentationCheck of checkstyle
Posted by Reynold Xin <rx...@databricks.com>.
+Herman
Is this coming from the newly merged Hive parser?
On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang <al...@126.com> wrote:
>
>
> format issue I think, go ahead
>
>
>
>
> At 2015-12-30 13:36:05, "Ted Yu" <yu...@gmail.com> wrote:
>
> Hi,
> I noticed that there are a lot of checkstyle warnings in the following
> form:
>
> <error line="1784" severity="error" message="'block' child have
> incorrect indentation level 8, expected level should be 10."
> source="com.puppycrawl.tools.checkstyle.
> checks.indentation.IndentationCheck"/>
>
> To my knowledge, we use two spaces for each tab. Not sure why all of a
> sudden we have so many IndentationCheck warnings:
>
> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
> 3133 52645 678294
>
> If there is no objection, I would create a JIRA and relax IndentationCheck
> warning.
>
> Cheers
>
>
>
>
>
Re:IndentationCheck of checkstyle
Posted by Allen Zhang <al...@126.com>.
format issue I think, go ahead
At 2015-12-30 13:36:05, "Ted Yu" <yu...@gmail.com> wrote:
Hi,
I noticed that there are a lot of checkstyle warnings in the following form:
<error line="1784" severity="error" message="'block' child have incorrect indentation level 8, expected level should be 10." source="com.puppycrawl.tools.checkstyle. checks.indentation.IndentationCheck"/>
To my knowledge, we use two spaces for each tab. Not sure why all of a sudden we have so many IndentationCheck warnings:
grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
3133 52645 678294
If there is no objection, I would create a JIRA and relax IndentationCheck warning.
Cheers
IndentationCheck of checkstyle
Posted by Ted Yu <yu...@gmail.com>.
> Hi,
> I noticed that there are a lot of checkstyle warnings in the following form:
>
> <error line="1784" severity="error" message="'block' child have incorrect indentation level 8, expected level should be 10." source="com.puppycrawl.tools.checkstyle. checks.indentation.IndentationCheck"/>
>
> To my knowledge, we use two spaces for each tab. Not sure why all of a sudden we have so many IndentationCheck warnings:
>
> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
> 3133 52645 678294
>
> If there is no objection, I would create a JIRA and relax IndentationCheck warning.
>
> Cheers