You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/23 18:58:48 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4345: minor: improve optimizer logging and do not repeat rule name
alamb opened a new pull request, #4345:
URL: https://github.com/apache/arrow-datafusion/pull/4345
# Which issue does this PR close?
N/A
# Rationale for this change
I am debugging something wrong in one of the optimizer passes it wasn't immediately obvious to me from the logging that some passes didn't change the plan at all.
# What changes are included in this PR?
Do not log the plan for optimizer passes that didn't make changes
# Are these changes tested?
Not really
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4345: minor: improve optimizer logging and do not repeat rule name
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4345:
URL: https://github.com/apache/arrow-datafusion/pull/4345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4345: minor: improve optimizer logging and do not repeat rule name
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4345:
URL: https://github.com/apache/arrow-datafusion/pull/4345#issuecomment-1328106812
Benchmark runs are scheduled for baseline = 27ae14aeec840f404d5ebe44e341f5dbea4c6f63 and contender = 323fbb43a3359d59bd12daf6d2b38102b4671d6f. 323fbb43a3359d59bd12daf6d2b38102b4671d6f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/92777eb1ddc145c2a73e82eb0eafe2ff...cabdf9ba5d374a189e47a1627868d4eb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3f57e2106f6a487d8ab52942402cfac0...79bcd44c5e004f4d8848e7763f707559/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/22f438e4c7864458b9d17a50642dcd39...6d4fae72d7ce486eb8daa24a9faf9f9a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9039b77524a64c47a4bdaa6df42549ea...57cfb19177c745d58f2a35d77ea122ea/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org