You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/09/17 03:20:55 UTC
Review Request 38445: Restart Of NodeManager During Rolling Upgrade
Runs Command As the Wrong User
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38445/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-13120
https://issues.apache.org/jira/browse/AMBARI-13120
Repository: ambari
Description
-------
During a rolling upgrade, the command which checks to see if the YARN NodeManager has rejoined the cluster is being executed as the hdfs user. This will cause problems in a kerberized environment since the kinit command is for the yarn user.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py 54e0fae
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 6794097
Diff: https://reviews.apache.org/r/38445/diff/
Testing
-------
mvn clean test
----------------------------------------------------------------------
Total run:774
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 38445: Restart Of NodeManager During Rolling
Upgrade Runs Command As the Wrong User
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Sept. 17, 2015, 10:05 a.m., Nate Cole wrote:
> > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py, lines 537-539
> > <https://reviews.apache.org/r/38445/diff/1/?file=1075825#file1075825line537>
> >
> > Maybe add another assertion that the user is the yarn user? Useful when it gets changed back to hdfs user by questionable parties.
Good catch; updated the test.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38445/#review99381
-----------------------------------------------------------
On Sept. 16, 2015, 9:20 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38445/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 9:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-13120
> https://issues.apache.org/jira/browse/AMBARI-13120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During a rolling upgrade, the command which checks to see if the YARN NodeManager has rejoined the cluster is being executed as the hdfs user. This will cause problems in a kerberized environment since the kinit command is for the yarn user.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py 54e0fae
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 6794097
>
> Diff: https://reviews.apache.org/r/38445/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ----------------------------------------------------------------------
> Total run:774
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 38445: Restart Of NodeManager During Rolling
Upgrade Runs Command As the Wrong User
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38445/#review99381
-----------------------------------------------------------
Ship it!
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py (lines 537 - 539)
<https://reviews.apache.org/r/38445/#comment156258>
Maybe add another assertion that the user is the yarn user? Useful when it gets changed back to hdfs user by questionable parties.
- Nate Cole
On Sept. 16, 2015, 9:20 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38445/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 9:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-13120
> https://issues.apache.org/jira/browse/AMBARI-13120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During a rolling upgrade, the command which checks to see if the YARN NodeManager has rejoined the cluster is being executed as the hdfs user. This will cause problems in a kerberized environment since the kinit command is for the yarn user.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py 54e0fae
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 6794097
>
> Diff: https://reviews.apache.org/r/38445/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ----------------------------------------------------------------------
> Total run:774
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>