You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Shanthoosh Venkataraman <sa...@gmail.com> on 2016/09/23 23:19:04 UTC
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/
-----------------------------------------------------------
(Updated Sept. 23, 2016, 11:19 p.m.)
Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Summary (updated)
-----------------
SAMZA-1024 : Enable passing of Configs and MetricsRegistry into Monitor objects.
Repository: samza
Description
-------
This patch aims at adding the following functionalities to Samza-Rest monitors.
* Schedule different monitors at different intervals of time.
* Define custom monitor configurations and pass config along to the monitor
objects.
Diffs (updated)
-----
docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
samza-rest/src/main/java/org/apache/samza/monitor/AbstractMonitor.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/51703/diff/
Testing
-------
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Shanthoosh Venkataraman <sa...@gmail.com>.
> On Sept. 26, 2016, 7:37 p.m., Jake Maes wrote:
> > samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java, lines 81-84
> > <https://reviews.apache.org/r/51703/diff/4/?file=1509611#file1509611line81>
> >
> > If I'm reading this correctly, this test depends on MapConfig to retain order of the configs, and that may not hold true.
Order of the config does not matter here, since there are no common keys betwen two config maps. Combining two config maps into one config object, would not cause problem due to uniqueness of all the keys.
> On Sept. 26, 2016, 7:37 p.m., Jake Maes wrote:
> > samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java, lines 63-68
> > <https://reviews.apache.org/r/51703/diff/4/?file=1509611#file1509611line63>
> >
> > I think it's importand to have some kind of follow-up test after instantiation to make sure the monitor was actually instantiated and returned, rather than null, for example.
> >
> > Minimum requirements would be
> > 1. not null
> > 2. instance of Monitor
Instance of Monitor is always true, since the factory returns Monitor object back. Added not null & monitor checks.
- Shanthoosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150435
-----------------------------------------------------------
On Sept. 24, 2016, 12:34 a.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2016, 12:34 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <jm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150435
-----------------------------------------------------------
docs/learn/documentation/versioned/rest/monitors.md (line 28)
<https://reviews.apache.org/r/51703/#comment218418>
This paragraph begins the same way as the first one. It's a little repetitive. Can it be reworded?
"the creation of" is unnecessary.
The word "individual" is unnecessary here.
In general, this paragraph isn't very user-friendly. As a user, I just want it to tell me what I can do and how to do it.
docs/learn/documentation/versioned/rest/monitors.md (line 30)
<https://reviews.apache.org/r/51703/#comment218417>
Please follow the instructions under /docs/README.md to test the site.
In particular, this file doesn't build.
```
docs[master] > bundle exec jekyll build
Configuration file: /.../samza/samza/docs/_config.yml
Source: /.../samza/samza/docs
Destination: /.../samza/samza/docs/_site
Generating...
Liquid Exception: Unknown tag 'monitorName' in learn/documentation/versioned/rest/monitors.md
jekyll 2.0.3 | Error: Unknown tag 'monitorName'
```
docs/learn/documentation/versioned/rest/monitors.md (line 33)
<https://reviews.apache.org/r/51703/#comment218421>
"individual" is unnecessary here
"should be defined" == "are required"
docs/learn/documentation/versioned/rest/monitors.md (lines 82 - 85)
<https://reviews.apache.org/r/51703/#comment218423>
This section feels out of place and is perhaps unnecessary because we don't yet support metrics.
docs/learn/documentation/versioned/rest/monitors.md (line 91)
<https://reviews.apache.org/r/51703/#comment218422>
"will be used to instantiate your Monitor."
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java (line 61)
<https://reviews.apache.org/r/51703/#comment218425>
Doesn't this method belong in MonitorConfig?
It has more to do with config structure than loading.
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java (line 50)
<https://reviews.apache.org/r/51703/#comment218428>
Unused.
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java (line 93)
<https://reviews.apache.org/r/51703/#comment218429>
Unused.
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java (line 60)
<https://reviews.apache.org/r/51703/#comment218430>
I think it's importand to have some kind of follow-up test after instantiation to make sure the monitor was actually instantiated and returned, rather than null, for example.
Minimum requirements would be
1. not null
2. instance of Monitor
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java (lines 73 - 76)
<https://reviews.apache.org/r/51703/#comment218432>
If I'm reading this correctly, this test depends on MapConfig to retain order of the configs, and that may not hold true.
- Jake Maes
On Sept. 24, 2016, 12:34 a.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2016, 12:34 a.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <jm...@apache.org>.
> On Sept. 26, 2016, 9:46 p.m., Jake Maes wrote:
> > docs/learn/documentation/versioned/rest/monitors.md, lines 43-50
> > <https://reviews.apache.org/r/51703/diff/5/?file=1510337#file1510337line43>
> >
> > These properties replace monitor.classes and monitor.run.interval.ms, right?
> >
> > If so, those properties should be removed from overview.md
NM, I was looking at a delta. I can see that this change was already made.
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150462
-----------------------------------------------------------
On Sept. 26, 2016, 9:13 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 9:13 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <jm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150462
-----------------------------------------------------------
Almost there. 2 more comments. Also, remember to attach the patch to the JIRA as described here:
http://samza.apache.org/contribute/rules.html
docs/learn/documentation/versioned/rest/monitors.md (lines 43 - 50)
<https://reviews.apache.org/r/51703/#comment218451>
These properties replace monitor.classes and monitor.run.interval.ms, right?
If so, those properties should be removed from overview.md
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java (line 88)
<https://reviews.apache.org/r/51703/#comment218450>
Sorry, I meant that here is where I think order matters.
MonitorLoader.extractMonitorConfigs() traverses the keyset of the Map in MapConfig. The order of that keyset is not guaranteed, so it can be in a different order than the "expected" List.
- Jake Maes
On Sept. 26, 2016, 9:13 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 9:13 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <jm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150571
-----------------------------------------------------------
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java (line 55)
<https://reviews.apache.org/r/51703/#comment218586>
It would be good to split this method into two parts for modularity and readability.
1. List<String> getMonitorNames() which is very similar to SystemConfig.getSystemNames()
2. Map<String, MonitorConfig> getMonitorConfigs(config, monitorNames)
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java (line 62)
<https://reviews.apache.org/r/51703/#comment218583>
putIfAbsent doesn't exist in Java 7
A simple put() should suffice.
If you want to make sure the same key isn't added twice, you could assert that the return value of put() is null. I think that case should be an error because the way the current code supports it, the behavior is not well-defined.
- Jake Maes
On Sept. 26, 2016, 11:14 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 11:14 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
> JIRA ticket : https://issues.apache.org/jira/browse/SAMZA-1024
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <jm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150600
-----------------------------------------------------------
Ship it!
Ship It!
- Jake Maes
On Sept. 27, 2016, 6:57 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2016, 6:57 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
> JIRA ticket : https://issues.apache.org/jira/browse/SAMZA-1024
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Shanthoosh Venkataraman <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/
-----------------------------------------------------------
(Updated Sept. 27, 2016, 6:57 p.m.)
Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description
-------
This patch aims at adding the following functionalities to Samza-Rest monitors.
* Schedule different monitors at different intervals of time.
* Define custom monitor configurations and pass config along to the monitor
objects.
JIRA ticket : https://issues.apache.org/jira/browse/SAMZA-1024
Diffs (updated)
-----
docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/51703/diff/
Testing
-------
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <jm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150574
-----------------------------------------------------------
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java (line 148)
<https://reviews.apache.org/r/51703/#comment218597>
One more minor issue.
Git doesn't like this extra newline at the end of the file.
- Jake Maes
On Sept. 26, 2016, 11:14 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 11:14 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
> JIRA ticket : https://issues.apache.org/jira/browse/SAMZA-1024
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Shanthoosh Venkataraman <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/
-----------------------------------------------------------
(Updated Sept. 26, 2016, 11:14 p.m.)
Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description (updated)
-------
This patch aims at adding the following functionalities to Samza-Rest monitors.
* Schedule different monitors at different intervals of time.
* Define custom monitor configurations and pass config along to the monitor
objects.
JIRA ticket : https://issues.apache.org/jira/browse/SAMZA-1024
Diffs (updated)
-----
docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/51703/diff/
Testing
-------
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Shanthoosh Venkataraman <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/
-----------------------------------------------------------
(Updated Sept. 26, 2016, 9:13 p.m.)
Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description
-------
This patch aims at adding the following functionalities to Samza-Rest monitors.
* Schedule different monitors at different intervals of time.
* Define custom monitor configurations and pass config along to the monitor
objects.
Diffs (updated)
-----
docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/51703/diff/
Testing
-------
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Shanthoosh Venkataraman <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/
-----------------------------------------------------------
(Updated Sept. 24, 2016, 12:34 a.m.)
Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description
-------
This patch aims at adding the following functionalities to Samza-Rest monitors.
* Schedule different monitors at different intervals of time.
* Define custom monitor configurations and pass config along to the monitor
objects.
Diffs (updated)
-----
docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/51703/diff/
Testing
-------
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
Re: Review Request 51703: SAMZA-1024 : Enable passing of Configs and
MetricsRegistry into Monitor objects.
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150262
-----------------------------------------------------------
Will take another look Monday, particularly at the documentation. But here's some quick feedback.
samza-rest/src/main/java/org/apache/samza/monitor/AbstractMonitor.java (line 29)
<https://reviews.apache.org/r/51703/#comment218155>
I think this abstract class can now be removed. See below.
samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java (lines 57 - 60)
<https://reviews.apache.org/r/51703/#comment218152>
Since the instantiateMonitors method has the MonitorConfig for each Monitor, does it make sense to pass the scheduler to that method and schedule it there.
That way, we can read the monitor config directly to get the interval, rather than exposing a method in the monitor (getSchedulingIntervalInMs)
- Jake Maes
On Sept. 23, 2016, 11:19 p.m., Shanthoosh Venkataraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51703/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2016, 11:19 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> This patch aims at adding the following functionalities to Samza-Rest monitors.
>
> * Schedule different monitors at different intervals of time.
> * Define custom monitor configurations and pass config along to the monitor
> objects.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/rest/monitors.md 9833068d9f542b80bb438db156a10c85d4d53097
> docs/learn/documentation/versioned/rest/overview.md 5b958accf4e1a3f05b949e9dc6e2e19a453523ca
> samza-rest/src/main/java/org/apache/samza/monitor/AbstractMonitor.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/Monitor.java d69df5f73dbf2c494183f9dcc8061c20878742aa
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorConfig.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION
> samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 502ecc49f32b4563e8ceb4ddfa6bc2542c60819e
> samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981
> samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8
> samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 5b34da814985fb09281f36c677a97372cacc7a75
> samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java PRE-CREATION
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51703/diff/
>
>
> Testing
> -------
>
> Unit tests are used to verify the intended functionality.
>
>
> Thanks,
>
> Shanthoosh Venkataraman
>
>