[jira] [Commented] (ZOOKEEPER-2349) Update documentation for snapCount

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161953#comment-16161953 ] 

ASF GitHub Bot commented on ZOOKEEPER-2349:
-------------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/349


> Update documentation for snapCount
> ----------------------------------
>
>                 Key: ZOOKEEPER-2349
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2349
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Raghavendra Prabhu
>            Priority: Minor
>             Fix For: 3.6.0
>
>         Attachments: ZOOKEEPER-2349.patch
>
>
> The documentation states that 
> {code}
> ZooKeeper logs transactions to a transaction
> log. After snapCount transactions are written to a log
> file a snapshot is started and a new transaction log
> file is created. The default snapCount is
> 100,000.
> {code}
> However, in implementation, snapshotting is done when logCount is somwhere in (snapCount/2, snapCount+1], based on the limit set at runtime:  
> {code}
>         if (logCount > (snapCount / 2 + randRoll)) {
> {code}
> as in 
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java#L124



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)