You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/06/09 05:52:54 UTC
[GitHub] [bigtop] JunHe77 opened a new pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
JunHe77 opened a new pull request #783:
URL: https://github.com/apache/bigtop/pull/783
…sing aarch64 support
This is a follow-up patch of 0cabb0791e430ec0f710371cecd20b10c9ae815c
to solve the build failure on CentOS-7.
The reason is protoc included in com.github.os72::protoc doesn't work
with legacy centos-7 libc. so we use protoc built by bigtop_toolchain
to create a local jar.
Change-Id: I22b6158997adb946237121ed509159e21d7b6b45
Signed-off-by: Jun He <ju...@arm.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] JunHe77 commented on a change in pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
Posted by GitBox <gi...@apache.org>.
JunHe77 commented on a change in pull request #783:
URL: https://github.com/apache/bigtop/pull/783#discussion_r648123377
##########
File path: bigtop-packages/src/common/hive/do-component-build
##########
@@ -32,11 +32,21 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# Include common Maven Deployment logic
. $(dirname ${0})/maven_deploy.sh
+# workaround for BIGTOP-3548, as the protoc binary included in
+# com.github.os72::protoc doesn't work with legacy centos-7 libc
+# so we use protoc built by bigtop_toolchain to create a fake jar
+source /etc/os-release
+case ${ID}-${VERSION_ID} in
+ centos-7)
+ mvn install:install-file -DgroupId=com.github.os72 -DartifactId=protoc -Dversion=2.6.1-build3 \
+ -Dclassifier=linux-aarch_64 -Dpackaging=exe -Dfile=/usr/local/bin/protoc
Review comment:
"linux-aarch_64" is hardcoded. This should be changed to reflect certain non-x86 platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #783:
URL: https://github.com/apache/bigtop/pull/783#discussion_r648019391
##########
File path: bigtop-packages/src/common/hive/do-component-build
##########
@@ -32,11 +32,21 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# Include common Maven Deployment logic
. $(dirname ${0})/maven_deploy.sh
+# workaround for BIGTOP-3548, as the protoc binary included in
+# com.github.os72::protoc doesn't work with legacy centos-7 libc
+# so we use protoc built by bigtop_toolchain to create a fake jar
+source /etc/os-release
+case ${ID}-${VERSION_ID} in
+ centos-7)
+ mvn install:install-file -DgroupId=com.github.os72 -DartifactId=protoc -Dversion=2.6.1-build3 \
Review comment:
protoc built by bigtop_toolchain is 2.5.0. If we can use local protoc artifact, how about set the version back to 2.5.0 for all distros/archs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #783:
URL: https://github.com/apache/bigtop/pull/783#discussion_r648179507
##########
File path: bigtop-packages/src/common/hive/do-component-build
##########
@@ -32,11 +32,21 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# Include common Maven Deployment logic
. $(dirname ${0})/maven_deploy.sh
+# workaround for BIGTOP-3548, as the protoc binary included in
+# com.github.os72::protoc doesn't work with legacy centos-7 libc
+# so we use protoc built by bigtop_toolchain to create a fake jar
+source /etc/os-release
+case ${ID}-${VERSION_ID} in
+ centos-7)
+ mvn install:install-file -DgroupId=com.github.os72 -DartifactId=protoc -Dversion=2.6.1-build3 \
Review comment:
Hadoop already depend on protoc built by bigtop_toolchain (on aarch64 and ppc64le). Phoenix will do so by #786. Asking users for using bigtop_toolchain on aarch64 and ppc64le should be reasonable. Since the fix version of HIVE-21939 is 4.0.0, it is not tested on the field. Removing patch6-HIVE-21939.diff should be safer if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] JunHe77 commented on a change in pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
Posted by GitBox <gi...@apache.org>.
JunHe77 commented on a change in pull request #783:
URL: https://github.com/apache/bigtop/pull/783#discussion_r648821488
##########
File path: bigtop-packages/src/common/hive/do-component-build
##########
@@ -32,11 +32,21 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# Include common Maven Deployment logic
. $(dirname ${0})/maven_deploy.sh
+# workaround for BIGTOP-3548, as the protoc binary included in
+# com.github.os72::protoc doesn't work with legacy centos-7 libc
+# so we use protoc built by bigtop_toolchain to create a fake jar
+source /etc/os-release
+case ${ID}-${VERSION_ID} in
+ centos-7)
+ mvn install:install-file -DgroupId=com.github.os72 -DartifactId=protoc -Dversion=2.6.1-build3 \
Review comment:
Ya. It makes sense to use the same solution to fix the same protoc problem across hive/hbase/phoenix. Will update patch soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims merged pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
Posted by GitBox <gi...@apache.org>.
iwasakims merged pull request #783:
URL: https://github.com/apache/bigtop/pull/783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] JunHe77 commented on a change in pull request #783: BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…
Posted by GitBox <gi...@apache.org>.
JunHe77 commented on a change in pull request #783:
URL: https://github.com/apache/bigtop/pull/783#discussion_r648110008
##########
File path: bigtop-packages/src/common/hive/do-component-build
##########
@@ -32,11 +32,21 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# Include common Maven Deployment logic
. $(dirname ${0})/maven_deploy.sh
+# workaround for BIGTOP-3548, as the protoc binary included in
+# com.github.os72::protoc doesn't work with legacy centos-7 libc
+# so we use protoc built by bigtop_toolchain to create a fake jar
+source /etc/os-release
+case ${ID}-${VERSION_ID} in
+ centos-7)
+ mvn install:install-file -DgroupId=com.github.os72 -DartifactId=protoc -Dversion=2.6.1-build3 \
Review comment:
That should work. Actually, I'm a bit hesitating on which way we need to use: just create a local 2.5.0 artifact or backport upstream patch (HIVE-21939) while making a hack for CentOS-7 as well. I'm just wondering if there is a possibility that a user directly builds the source and patches in srpm/sdeb without bigtop toolchain. If that is a case it might be better to align with HIVE upstream as much as possible while creating a little hack here in the build script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org