[GitHub] [ozone] adoroszlai commented on a change in pull request #3106: HDDS-6327. Upgrade acceptance test doesn't collect logs when the test fails

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #3106:
URL: https://github.com/apache/ozone/pull/3106#discussion_r808912805



##########
File path: hadoop-ozone/dist/src/main/compose/upgrade/testlib.sh
##########
@@ -94,8 +94,8 @@ run_test() {
     RESULT=1
   fi
 
-  generate_report 'upgrade' "$RESULT_DIR"
   copy_results "$test_subdir" "$ALL_RESULT_DIR"
+  generate_report 'upgrade' "$RESULT_DIR"

Review comment:
       Can we remove the `generate_report` call completely?
   
   `run_test` is called from `test.sh`, where it is immediately followed by `generate_report`:
   
   https://github.com/apache/ozone/blob/c87b059b0f475c8af08f1ae7ead9f5e193e9df57/hadoop-ozone/dist/src/main/compose/upgrade/test.sh#L35-L37




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org