You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/20 17:29:24 UTC
[GitHub] [airflow] Jorricks opened a new pull request #16550: FIX Orphaned tasks stuck in executor as running
Jorricks opened a new pull request #16550:
URL: https://github.com/apache/airflow/pull/16550
Related: https://github.com/apache/airflow/issues/13542
The issue discussed here was caused by multiple things.
One of the issues is that when the scheduler picks up 'assumed to be' `orphaned` tasks, these tasks might have never made it to celery.
When the tasks execution never happens, it is automatically cleaned up but only partially.
Then once the scheduler retries to queue the task again, it won't be able to, because there is still a reference of the task in the set of the `running` variable.
This PR should fix the described issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks removed a comment on pull request #16550: FIX Orphaned tasks stuck in executor as running
Posted by GitBox <gi...@apache.org>.
Jorricks removed a comment on pull request #16550:
URL: https://github.com/apache/airflow/pull/16550#issuecomment-865291314
For future work:
- Do not adopt tasks that are in PENDING state on the celery side.
- Update the test with a mocking that prevents the states from being fetched as PENDING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #16550: FIX Orphaned tasks stuck in executor as running
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #16550:
URL: https://github.com/apache/airflow/pull/16550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16550: FIX Orphaned tasks stuck in executor as running
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16550:
URL: https://github.com/apache/airflow/pull/16550#issuecomment-864586773
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks commented on pull request #16550: FIX Orphaned tasks stuck in executor as running
Posted by GitBox <gi...@apache.org>.
Jorricks commented on pull request #16550:
URL: https://github.com/apache/airflow/pull/16550#issuecomment-865291314
For future work:
- Do not adopt tasks that are in PENDING state on the celery side.
- Update the test with a mocking that prevents the states from being fetched as PENDING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16550: FIX Orphaned tasks stuck in executor as running
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16550:
URL: https://github.com/apache/airflow/pull/16550#issuecomment-865696091
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks commented on pull request #16550: FIX Orphaned tasks stuck in executor as running
Posted by GitBox <gi...@apache.org>.
Jorricks commented on pull request #16550:
URL: https://github.com/apache/airflow/pull/16550#issuecomment-865291314
For future work:
- Do not adopt tasks that are in PENDING state on the celery side.
- Update the test with a mocking that prevents the states from being fetched as PENDING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org