You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/09 21:02:29 UTC

[GitHub] [trafficserver] bneradt opened a new issue #7933: We should delete global_scrap_object code

bneradt opened a new issue #7933:
URL: https://github.com/apache/trafficserver/issues/7933


   While doing some logging work, I noticed that our code instantiates a so-called scrap LogObject:
   
   https://github.com/apache/trafficserver/blob/b85d9fd8481bc55547aade92f5b9cf7a8db5099f/proxy/logging/Log.cc#L1091=#L1095
   
   This object is never written to, thus it is dead code. Digging through our history, it looks like this used to be associated with log collation, a feature which was removed in #5353. Since that no longer exists, we can simply remove the scrap log object from our code.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt closed issue #7933: We should delete global_scrap_object code

Posted by GitBox <gi...@apache.org>.
bneradt closed issue #7933:
URL: https://github.com/apache/trafficserver/issues/7933


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org