You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "RunyaoChen (via GitHub)" <gi...@apache.org> on 2023/05/02 05:42:30 UTC

[GitHub] [spark] RunyaoChen commented on a diff in pull request #40989: [SPARK-43316][SQL] Add more CTE SQL tests

RunyaoChen commented on code in PR #40989:
URL: https://github.com/apache/spark/pull/40989#discussion_r1182106933


##########
sql/core/src/test/resources/sql-tests/inputs/cte.sql:
##########
@@ -53,6 +53,347 @@ SELECT * FROM t;
 WITH t AS (SELECT 1 FROM non_existing_table)
 SELECT 2;
 
+-- The following tests are ported from Postgres

Review Comment:
   Thanks for the pointer! I've removed the duplicated test cases from PostgreSQL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org