You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/04 20:53:21 UTC
[GitHub] [cordova-plugin-file] eliadAfeka opened a new pull request #410: support android 10 (API 29)
eliadAfeka opened a new pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691468624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691468624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-669496614
Blocked by https://github.com/apache/cordova-plugin-file/pull/411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] felipecaparelli commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
felipecaparelli commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-687667618
I'm just wondering, it this plugin.xml change the only thing needed to be compliant with Android 10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] jitendracodehacker edited a comment on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
jitendracodehacker edited a comment on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-674003919
@breautek Hi , When will you have support to API29. this has stopped our release as file-plugin fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] eliadAfeka commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
eliadAfeka commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691503953
hi,
sorry for the rush, but is everything ok with this PR? if yes, when you are going to upload it?
this plugin is critical in my projects.
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] eliadAfeka commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
eliadAfeka commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691503953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-671354675
@eliadAfeka Looks like you just reverted this PR via https://github.com/apache/cordova-plugin-file/pull/410/commits/28aa7121bc1968e96e21141e5c2a4c4a53813ebf, so that this no has no changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691468624
> I'm just wondering, it this plugin.xml change the only thing needed to be compliant with Android 10?
From what I've seen, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on a change in pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#discussion_r465993258
##########
File path: plugin.xml
##########
@@ -132,7 +132,9 @@ to config.xml in order for the application to find previously stored files.
</feature>
<allow-navigation href="cdvfile:*" />
</config-file>
-
+ <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
+ <application android:requestLegacyExternalStorage="true" />
Review comment:
Can you fix the tabbing here? Thanks
```suggestion
<edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
<application android:requestLegacyExternalStorage="true" />
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] smartyw commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
smartyw commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-702886584
I believe this PR, which was supposed to fix this issue was merged so I built against head just now but still get the same error INVALID_MODIFICATION_ERR when running on Android 10. Is this expected? Do I need to wait for an official release of the plugin? There's some urgency to get applications using target SDK 29 by November. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] jitendracodehacker commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
jitendracodehacker commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-674003919
Hi , When will you have support to API29. this has stopped our release as file-plugin fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek closed pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] eliadAfeka commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
eliadAfeka commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691503953
hi,
sorry for the rush, but is everything ok with this PR? if yes, when you are going to upload it?
this plugin is critical in my projects.
thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] EinfachHans commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
EinfachHans commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-822434635
@breautek Any chance we can get a new released Version here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691468624
> I'm just wondering, it this plugin.xml change the only thing needed to be compliant with Android 10?
From what I've seen, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] eliadAfeka commented on pull request #410: support android 10 (API 29)
Posted by GitBox <gi...@apache.org>.
eliadAfeka commented on pull request #410:
URL: https://github.com/apache/cordova-plugin-file/pull/410#issuecomment-691503953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org