[jira] [Commented] (HTTPCLIENT-2041) AuthenticationStrategy#select() assumes challanges key to be lowercase

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003374#comment-17003374 ] 

Michael Osipov commented on HTTPCLIENT-2041:
--------------------------------------------

This should be documented or internally copied with lowercased keys.

> AuthenticationStrategy#select() assumes challanges key to be lowercase
> ----------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2041
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2041
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async)
>    Affects Versions: 5.0 Beta6
>            Reporter: Michael Osipov
>            Priority: Major
>
> While working on branch {{consistent-use-authschemes#id}} I have noticed that {{AuthenticationStrategy#select()}} assumes all keys to be lowercase authPrefs are lowercased during comparsion. Unforatunately, the Javadoc of this method does not document this at all which can leave to subtile bugs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org