You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/02/24 03:16:06 UTC
[GitHub] zeppelin pull request #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & In...
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2037
[ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce "INTERPRETER" type
### What is this PR for?
* Make Helium pkgs sortable
For now, we have 3 types of Helium packages: `VISUALIZATION`, `SPELL` and `APPLICATION`.
`VISUALIZATION` and `SPELL` type of pkgs can be published [NPM registry](https://www.npmjs.com/). Likewise, `APPLICATION` type pkg can be registered in [Maven central repository](http://search.maven.org/).
But all available Helium packages are not sorted and shown in random order in Helium menu.
To do this, I put "NPM Packages" & "Maven Artifacts" button at top-right corner of Helium menu.
* Introduce "INTERPRETER" type
As a first step of [ZEPPELIN-1993: Install interpreter from Helium menu](https://issues.apache.org/jira/browse/ZEPPELIN-1993), I added `INTERPRETER` type as a new Helium pkg type. Like [ZEPPELIN-1973](https://issues.apache.org/jira/browse/ZEPPELIN-1973) did, we can retrieve Maven artifact(which has `zeppelin-interpreter` as its dependency) info and save it to Helium online registry as well.
For more detailed explanation, please see [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) and [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110)'s description.
### What type of PR is it?
Improvement
### Todos
* [ ] - address feedback
### What is the Jira issue?
* [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109) : Make Helium packages sortable in Helium menu
* [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110) : List community & 3rd party interpreter registered at Maven central repo in Helium menu
### How should this be tested?
To see how `INTERPRETER` type can be shown in Helium menu,
1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium-test.json)
2. Build \w below command and restart
```
$ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter'
```
3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000`
```
$ yarn run dev:helium
```
4. Go to Helium menu
### Screenshots (if appropriate)
- How's it look?
- Package selection by types (`VISUALIZATION`, `SPELL`, `INTERPRETER` and `APPLICATION`)
<img width="500" alt="screen shot 2017-02-23 at 12 51 22 am" src="https://cloud.githubusercontent.com/assets/10060731/23219377/3c020fb4-f962-11e6-849c-6da193414d87.png">
- Disabled "Enable" button until [ZEPPELIN-1993](https://issues.apache.org/jira/browse/ZEPPELIN-1993) is resolved
<img width="580px" alt="screen shot 2017-02-20 at 2 03 23 am" src="https://cloud.githubusercontent.com/assets/10060731/23104412/c95dccb2-f710-11e6-9602-4159c7182e64.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit 6de9169988dae72b084566fef7e401949d5287a4
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:46:05Z
Add img files
commit f1c7bac81e15f8dd577e1e96de698567e004b1f0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:47:17Z
Add 'INTERPRETER', 'APPLICATION' as helium pkg types
commit 4a6eace7a9a0356b21d93743105cbd3690a65d9e
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T16:51:00Z
Enable Helium pkg type sortable
commit b74c599178edc28c240ceb3ba9ac7f01b3d2faf1
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:12:16Z
Remove console.log
commit 86e1eda3ef7d1b79d2544864fd568ce22701c697
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-19T17:43:54Z
Remove unnecassary words
commit 6d7f4fab5be6dc4b568f238f9403872309386be0
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:37:39Z
Make packages sortable by type not repository
commit c68efd211bd1741c7d2efd1552d41e9164904694
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:45:27Z
Remove unused img files
commit 899e8fa8eba08a293821470a00c582145c64ea36
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-22T15:45:46Z
Put license sentences back removed by mistake
commit d5ae4e2f04a8f61cf2759c1595f776e8f8aa7fd9
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-02-23T07:36:00Z
Add default msg to show when each package size is 0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---