[GitHub] [zeppelin] cuspymd commented on a change in pull request #4162: [ZEPPELIN-5441] Check no jobs running before kill interpreter job in TimeoutLifecycleManager

[GitBox <gi...@apache.org>]

cuspymd commented on a change in pull request #4162:
URL: https://github.com/apache/zeppelin/pull/4162#discussion_r669665813



##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/lifecycle/TimeoutLifecycleManager.java
##########
@@ -53,7 +57,8 @@ public TimeoutLifecycleManager(ZeppelinConfiguration zConf,
     ScheduledExecutorService checkScheduler = ExecutorFactory.singleton()
         .createOrGetScheduled("TimeoutLifecycleManager", 1);
     checkScheduler.scheduleAtFixedRate(() -> {
-      if ((System.currentTimeMillis() - lastBusyTimeInMillis) > timeoutThreshold) {
+      if ((System.currentTimeMillis() - lastBusyTimeInMillis) > timeoutThreshold &&
+              noJobsRunning()) {

Review comment:
       According to the original design, if a job is running, shouldn't `lastBusyTimeInMilli` be updated?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org