post-revprop-change.tmpl references non-existent propchange-email.pl

[Ryan Schmidt <su...@ryandesign.com>]

post-revprop-change.tmpl in the hooks directory of a new repository  
created with Subversion 1.4.5 contains this line:

propchange-email.pl "$REPOS" "$REV" "$USER" "$PROPNAME"  
watchers@example.org

propchange-email.pl does not exist in Subversion 1.4.0 and later. Its  
functionality appears to have been merged into commit-email.pl:

http://svn.collab.net/viewvc/svn?view=rev&revision=19331

Can the default post-revprop-change.tmpl please be updated so that it  
shows how to use commit-email.pl for this?

I did not see an issue filed for this in the issue tracker. Should I  
submit one?

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: post-revprop-change.tmpl references non-existent propchange-email.pl

[Ryan Schmidt <su...@ryandesign.com>]

On Sep 5, 2007, at 11:00, Marc Girod wrote:

> Ryan Schmidt writes:
>
>> http://svn.collab.net/viewvc/svn?view=rev&revision=19331
>
> Thanks for this useful pointer!
>
> I was wondering what had happened. I could find an old
> version of the script from some other site, via Google,
> with references to a branch which has disappeared:
>
> http://opensource.polytechnique.org/viewsvn/filedetails.php? 
> repname=Diogenes&path=%2Fhooks%2Fpropchange-email.pl&sc=1
>
> The URL in the comments mentioned:
>  http://svn.collab.net/repos/svn/branches/release-0.31.0/...

Subversion 0.31.0 is clearly quite old. The script does still exist  
in the 1.3.1 branch:

http://svn.collab.net/viewvc/svn/branches/1.3.x/tools/hook-scripts/ 
propchange-email.pl.in?view=markup

But if the functionality has been merged into commit-email.pl, then  
that's the script we should be using, and it would be good if the  
example post-revprop-change hook would show us how this is done.

>> Can the default post-revprop-change.tmpl please be updated so that it
>> shows how to use commit-email.pl for this?
>
> I second this, for what it's worth...

Great, you can be my issue buddy. :) I've filed it here:

http://subversion.tigris.org/issues/show_bug.cgi?id=2911


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: post-revprop-change.tmpl references non-existent propchange-email.pl

[Marc Girod <ma...@iona.com>]

Hello,

Ryan Schmidt <subversion-2007b <at> ryandesign.com> writes:

> http://svn.collab.net/viewvc/svn?view=rev&revision=19331

Thanks for this useful pointer!

I was wondering what had happened. I could find an old 
version of the script from some other site, via Google,
with references to a branch which has disappeared:

http://opensource.polytechnique.org/viewsvn/filedetails.php?repname=Diogenes&path=%2Fhooks%2Fpropchange-email.pl&sc=1

The URL in the comments mentioned:
 http://svn.collab.net/repos/svn/branches/release-0.31.0/...

> Can the default post-revprop-change.tmpl please be updated so that it  
> shows how to use commit-email.pl for this?

I second this, for what it's worth...

Marc

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org