[jira] [Commented] (SOLR-10721) Provide a way to know when Core Discovery is finished and when all async cores are done loading

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018646#comment-16018646 ] 

Erick Erickson commented on SOLR-10721:
---------------------------------------

Thinking about this a little more, I can envision other kinds of states being added in the future. Rather than calls for various possibilities, what about starting out with just a long and some bit constants? That would give a more nuanced view and wouldn't require that the users know about stuff like "loading is finished, therefore core discovery is finished". 

The fact that setting two bits, call them LOAD_COMPLETED and DISCOVERY_FINISHED at the end of the load() method is an implementation detail.



> Provide a way to know when Core Discovery is finished and when all async cores are done loading
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10721
>                 URL: https://issues.apache.org/jira/browse/SOLR-10721
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>
> Custom transient core implementations could benefit from knowing two things:
> 1> that core discovery is over
> 2> that all cores that are going to be loaded have been loaded, i.e. all loadOnStartup cores are done.
> It should be trivial to add a method to CoreContainer like "isLoaded" that would answer the first question since you can't get past the load() method without all the cores being discovered. I think this is a more generally useful bit of information than just core discovery is done.
> As for the second, that too seems trivial, just add a method to CoreContainer that returns the number of entries in SolrCores.currentlyLoadingCores.
> I'll add this in a few days unless there are objections.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org