[GitHub] wohali opened a new pull request #968: Simplify make dist approach

[GitBox <gi...@apache.org>]

wohali opened a new pull request #968: Simplify make dist approach
URL: https://github.com/apache/couchdb/pull/968
 
 
   During the 2.1.1 release process there was a fault identified with the process. Even after checking out the `2.1.1` tag, a `make dist` command will build a tarball that has the git short hash in the directory name and the file name.
   
   This PR attempts to DRY out the process by checking if we are on a tag that matches the regex `^[0-9]+\.[0-9]\.[0-9]+(-RC[0-9]+)?$`. If so, that's the version used for the directory/tarball naming. If not, and we're inside of a git checkout (`.git` directory exists), append the git short version. If neither of those applies, we're already in a dist tarball - we use the pure #.#.# version from version.mk instead.
   
   One problem exists: if a checkout has multiple tags of the form (`2.1.1-RC2` and `2.1.1`), the `2.1.1` tag will be used. This is probably fine, as the only time we'll have duplicate tags on the same checkout is when an RC becomes a real release.
   
   Please read carefully and test. Place a copy of the modified Makefile at /tmp/Makefile and try the following:
   
   ```bash
   git checkout 2.1.1 && cp /tmp/Makefile Makefile && make dist
   git checkout 2.1.1-RC1 && cp /tmp/Makefile Makefile && make dist
   git checkout master && cp /tmp/Makefile Makefile && make dist
   ```
   
   and validate the output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services