You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2013/12/18 21:39:22 UTC
Review Request 16355: Fixing checkstyle for tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16355/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
Adding checkstyle for tests.
Diffs
-----
build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
src/test/java/com/twitter/aurora/scheduler/DriverFactoryImplTest.java bb4b1c514e6dc38b1723d57cb6c2388c919f06cd
src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java 3336875f53f3516a575be1eb0a6b8b6d381d70c5
src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d
src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12
src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java e6e60bf721a580c677b080f328e15ac4e808dc63
Diff: https://reviews.apache.org/r/16355/diff/
Testing
-------
$ gradle build
make: Nothing to be done for `all'.
:bootstrapThrift UP-TO-DATE
:generateSources UP-TO-DATE
:compileGeneratedJava UP-TO-DATE
:processGeneratedResources UP-TO-DATE
:generatedClasses UP-TO-DATE
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar UP-TO-DATE
:assemble UP-TO-DATE
:checkstyleMain UP-TO-DATE
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:checkstyleTest UP-TO-DATE
:test UP-TO-DATE
:check UP-TO-DATE
:build UP-TO-DATE
BUILD SUCCESSFUL
Total time: 2.049 secs
Thanks,
Maxim Khutornenko
Re: Review Request 16355: Fixing checkstyle for tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16355/#review30645
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Dec. 18, 2013, 8:39 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16355/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 8:39 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding checkstyle for tests.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
> src/test/java/com/twitter/aurora/scheduler/DriverFactoryImplTest.java bb4b1c514e6dc38b1723d57cb6c2388c919f06cd
> src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java 3336875f53f3516a575be1eb0a6b8b6d381d70c5
> src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d
> src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12
> src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java e6e60bf721a580c677b080f328e15ac4e808dc63
>
> Diff: https://reviews.apache.org/r/16355/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar UP-TO-DATE
> :assemble UP-TO-DATE
> :checkstyleMain UP-TO-DATE
> :compileTestJava UP-TO-DATE
> :processTestResources UP-TO-DATE
> :testClasses UP-TO-DATE
> :checkstyleTest UP-TO-DATE
> :test UP-TO-DATE
> :check UP-TO-DATE
> :build UP-TO-DATE
>
> BUILD SUCCESSFUL
>
> Total time: 2.049 secs
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16355: Fixing checkstyle for tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Dec. 19, 2013, 12:09 a.m., Zameer Manji wrote:
> > Maxim: Can you mark this review as submitted? Thanks.
I just pushed it and closed.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16355/#review30657
-----------------------------------------------------------
On Dec. 18, 2013, 10:11 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16355/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 10:11 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding checkstyle for tests.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
> src/main/java/com/twitter/aurora/scheduler/async/AsyncModule.java db07841543e554e269f6fe7b36d7f7232af21140
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java e5aeb8321e22c51eb3a5dad3d3dd1e26b7121b7d
> src/main/java/com/twitter/aurora/scheduler/async/TaskGroups.java f95f719c5a444b0f8faa4330852e251dd5de528e
> src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java fbd82ff70235294cfd27c242f141a585d6bb2396
> src/test/java/com/twitter/aurora/scheduler/DriverFactoryImplTest.java bb4b1c514e6dc38b1723d57cb6c2388c919f06cd
> src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java 3336875f53f3516a575be1eb0a6b8b6d381d70c5
> src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerImplTest.java PRE-CREATION
> src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d
> src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12
> src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java e6e60bf721a580c677b080f328e15ac4e808dc63
> src/test/java/com/twitter/aurora/scheduler/state/PubsubTestUtil.java f9d7fb64728008d0ea6eb424283b58e956e1d50a
>
> Diff: https://reviews.apache.org/r/16355/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar UP-TO-DATE
> :assemble UP-TO-DATE
> :checkstyleMain UP-TO-DATE
> :compileTestJava UP-TO-DATE
> :processTestResources UP-TO-DATE
> :testClasses UP-TO-DATE
> :checkstyleTest UP-TO-DATE
> :test UP-TO-DATE
> :check UP-TO-DATE
> :build UP-TO-DATE
>
> BUILD SUCCESSFUL
>
> Total time: 2.049 secs
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16355: Fixing checkstyle for tests.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16355/#review30657
-----------------------------------------------------------
Maxim: Can you mark this review as submitted? Thanks.
- Zameer Manji
On Dec. 18, 2013, 2:11 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16355/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 2:11 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding checkstyle for tests.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
> src/main/java/com/twitter/aurora/scheduler/async/AsyncModule.java db07841543e554e269f6fe7b36d7f7232af21140
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java e5aeb8321e22c51eb3a5dad3d3dd1e26b7121b7d
> src/main/java/com/twitter/aurora/scheduler/async/TaskGroups.java f95f719c5a444b0f8faa4330852e251dd5de528e
> src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java fbd82ff70235294cfd27c242f141a585d6bb2396
> src/test/java/com/twitter/aurora/scheduler/DriverFactoryImplTest.java bb4b1c514e6dc38b1723d57cb6c2388c919f06cd
> src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java 3336875f53f3516a575be1eb0a6b8b6d381d70c5
> src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerImplTest.java PRE-CREATION
> src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d
> src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12
> src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java e6e60bf721a580c677b080f328e15ac4e808dc63
> src/test/java/com/twitter/aurora/scheduler/state/PubsubTestUtil.java f9d7fb64728008d0ea6eb424283b58e956e1d50a
>
> Diff: https://reviews.apache.org/r/16355/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar UP-TO-DATE
> :assemble UP-TO-DATE
> :checkstyleMain UP-TO-DATE
> :compileTestJava UP-TO-DATE
> :processTestResources UP-TO-DATE
> :testClasses UP-TO-DATE
> :checkstyleTest UP-TO-DATE
> :test UP-TO-DATE
> :check UP-TO-DATE
> :build UP-TO-DATE
>
> BUILD SUCCESSFUL
>
> Total time: 2.049 secs
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 16355: Fixing checkstyle for tests.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16355/
-----------------------------------------------------------
(Updated Dec. 18, 2013, 10:11 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Merging master.
Repository: aurora
Description
-------
Adding checkstyle for tests.
Diffs (updated)
-----
build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
src/main/java/com/twitter/aurora/scheduler/async/AsyncModule.java db07841543e554e269f6fe7b36d7f7232af21140
src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java e5aeb8321e22c51eb3a5dad3d3dd1e26b7121b7d
src/main/java/com/twitter/aurora/scheduler/async/TaskGroups.java f95f719c5a444b0f8faa4330852e251dd5de528e
src/main/java/com/twitter/aurora/scheduler/async/TaskScheduler.java fbd82ff70235294cfd27c242f141a585d6bb2396
src/test/java/com/twitter/aurora/scheduler/DriverFactoryImplTest.java bb4b1c514e6dc38b1723d57cb6c2388c919f06cd
src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java 3336875f53f3516a575be1eb0a6b8b6d381d70c5
src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerImplTest.java PRE-CREATION
src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d
src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12
src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java e6e60bf721a580c677b080f328e15ac4e808dc63
src/test/java/com/twitter/aurora/scheduler/state/PubsubTestUtil.java f9d7fb64728008d0ea6eb424283b58e956e1d50a
Diff: https://reviews.apache.org/r/16355/diff/
Testing
-------
$ gradle build
make: Nothing to be done for `all'.
:bootstrapThrift UP-TO-DATE
:generateSources UP-TO-DATE
:compileGeneratedJava UP-TO-DATE
:processGeneratedResources UP-TO-DATE
:generatedClasses UP-TO-DATE
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar UP-TO-DATE
:assemble UP-TO-DATE
:checkstyleMain UP-TO-DATE
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:checkstyleTest UP-TO-DATE
:test UP-TO-DATE
:check UP-TO-DATE
:build UP-TO-DATE
BUILD SUCCESSFUL
Total time: 2.049 secs
Thanks,
Maxim Khutornenko
Re: Review Request 16355: Fixing checkstyle for tests.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16355/#review30639
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Dec. 18, 2013, 12:39 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16355/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 12:39 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding checkstyle for tests.
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
> src/test/java/com/twitter/aurora/scheduler/DriverFactoryImplTest.java bb4b1c514e6dc38b1723d57cb6c2388c919f06cd
> src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java 3336875f53f3516a575be1eb0a6b8b6d381d70c5
> src/test/java/com/twitter/aurora/scheduler/async/TaskSchedulerTest.java a747f2b1ecbad7263931aeec3b12711096d2469d
> src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12
> src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java e6e60bf721a580c677b080f328e15ac4e808dc63
>
> Diff: https://reviews.apache.org/r/16355/diff/
>
>
> Testing
> -------
>
> $ gradle build
> make: Nothing to be done for `all'.
> :bootstrapThrift UP-TO-DATE
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :jar UP-TO-DATE
> :assemble UP-TO-DATE
> :checkstyleMain UP-TO-DATE
> :compileTestJava UP-TO-DATE
> :processTestResources UP-TO-DATE
> :testClasses UP-TO-DATE
> :checkstyleTest UP-TO-DATE
> :test UP-TO-DATE
> :check UP-TO-DATE
> :build UP-TO-DATE
>
> BUILD SUCCESSFUL
>
> Total time: 2.049 secs
>
>
> Thanks,
>
> Maxim Khutornenko
>
>