[jira] [Updated] (XERCESJ-1276) XMLSchemaValidator$ValueStoreBase.contains() is painfully slow

["Natan Cox (JIRA)" <xe...@xml.apache.org>]

     [ https://issues.apache.org/jira/browse/XERCESJ-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Natan Cox updated XERCESJ-1276:
-------------------------------

    Attachment: XMLSchemaValidator.java

I too had the same problem. The reason is that for comparison it loops over a Vector.

I created a fix that improves performance from 5000s to 27s on my laptop for a big file.

I added a fValueSet to do faster lookups. I filled and cleared everywhere where fValues is filled or cleared. And I added a "isContainsCandidate" check to rule out any candidates who do not have all values in fValueSet. If we cannot rule out (which should be the exception) the main algorithm kicks in again.

> XMLSchemaValidator$ValueStoreBase.contains() is painfully slow
> --------------------------------------------------------------
>
>                 Key: XERCESJ-1276
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1276
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: XML Schema 1.0 Structures
>    Affects Versions: 2.6.2, 2.9.1
>            Reporter: Kenny MacLeod
>         Attachments: XMLSchemaValidator.java
>
>
> Under certain conditions, the contains() method in XMLSchemaValidator$ValueStoreBase can cripple the performance of parsing and validation.
> I'm not sure what those conditions are, but as a guideline figure I was using JAXB2 to deserialize a 22meg XML file.  Without schema validation, it took 5 seconds.  With validation, it took over 3 minutes (JDK 1.5.0_10 on win32). My profiler pointed the finger squarely at that method XMLSchemaValidator.
> Suspicions were aroused further when seeing this comment in the source:
> public boolean contains() {
>             // REVISIT: we can improve performance by using hash codes, instead of
>             // traversing global vector that could be quite large.
> This is present in Xerces 2.6.2 contained with JDK1.5.0_10, and also in the source for 2.9.1.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org