You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Uwe Schindler <uw...@thetaphi.de> on 2014/02/05 18:16:20 UTC
RE: svn commit: r1564834 - in /lucene/dev/branches/branch_4x: ./ dev-tools/ lucene/ lucene/analysis/ lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/std40/ lucene/analysis/icu/src/java/org/apache/lucene/collation/ lucene/backwards/ luc
Hi Hoss,
Thanks for reverting. At the time when I added the Ignore, the test failed for me locally, so I am not aware if it was fixed in the meantime. Maybe the fix was committed at the same time.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: hossman@apache.org [mailto:hossman@apache.org]
> Sent: Wednesday, February 05, 2014 6:11 PM
> To: commits@lucene.apache.org
> Subject: svn commit: r1564834 - in /lucene/dev/branches/branch_4x: ./ dev-
> tools/ lucene/ lucene/analysis/
> lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/std
> 40/ lucene/analysis/icu/src/java/org/apache/lucene/collation/
> lucene/backwards/ luce...
>
> Author: hossman
> Date: Wed Feb 5 17:11:27 2014
> New Revision: 1564834
>
> URL: http://svn.apache.org/r1564834
> Log:
> SOLR-5623: revert r1564739, shalin already fixed the bug that caused these
> failures, but Uwe didn't know that (merge r1564831)
>
> Modified:
> lucene/dev/branches/branch_4x/ (props changed)
> lucene/dev/branches/branch_4x/dev-tools/ (props changed)
> lucene/dev/branches/branch_4x/lucene/ (props changed)
> lucene/dev/branches/branch_4x/lucene/BUILD.txt (props changed)
> lucene/dev/branches/branch_4x/lucene/CHANGES.txt (props changed)
> lucene/dev/branches/branch_4x/lucene/JRE_VERSION_MIGRATION.txt
> (props changed)
> lucene/dev/branches/branch_4x/lucene/LICENSE.txt (props changed)
> lucene/dev/branches/branch_4x/lucene/MIGRATE.txt (props changed)
> lucene/dev/branches/branch_4x/lucene/NOTICE.txt (props changed)
> lucene/dev/branches/branch_4x/lucene/README.txt (props changed)
> lucene/dev/branches/branch_4x/lucene/SYSTEM_REQUIREMENTS.txt
> (props changed)
> lucene/dev/branches/branch_4x/lucene/analysis/ (props changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/ASCIITLD.jflex-macro (props changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/SUPPLEMENTARY.jflex-macro (props
> changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/StandardTokenizerImpl40.java (props
> changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/StandardTokenizerImpl40.jflex (props
> changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/UAX29URLEmailTokenizerImpl40.java
> (props changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/UAX29URLEmailTokenizerImpl40.jflex
> (props changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/common/src/java/org/apa
> che/lucene/analysis/standard/std40/package.html (props changed)
>
> lucene/dev/branches/branch_4x/lucene/analysis/icu/src/java/org/apache/l
> ucene/collation/ICUCollationKeyFilterFactory.java (props changed)
> lucene/dev/branches/branch_4x/lucene/backwards/ (props changed)
> lucene/dev/branches/branch_4x/lucene/benchmark/ (props changed)
> lucene/dev/branches/branch_4x/lucene/build.xml (props changed)
> lucene/dev/branches/branch_4x/lucene/classification/ (props changed)
> lucene/dev/branches/branch_4x/lucene/classification/build.xml (props
> changed)
> lucene/dev/branches/branch_4x/lucene/classification/ivy.xml (props
> changed)
> lucene/dev/branches/branch_4x/lucene/classification/src/ (props
> changed)
> lucene/dev/branches/branch_4x/lucene/codecs/ (props changed)
> lucene/dev/branches/branch_4x/lucene/common-build.xml (props
> changed)
> lucene/dev/branches/branch_4x/lucene/core/ (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/i
> ndex/TestBackwardsCompatibility.java (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/i
> ndex/index.40.cfs.zip (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/i
> ndex/index.40.nocfs.zip (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/i
> ndex/index.40.optimized.cfs.zip (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/i
> ndex/index.40.optimized.nocfs.zip (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/s
> earch/TestSort.java (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/s
> earch/TestSortDocValues.java (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/s
> earch/TestSortRandom.java (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/s
> earch/TestTopFieldCollector.java (props changed)
>
> lucene/dev/branches/branch_4x/lucene/core/src/test/org/apache/lucene/s
> earch/TestTotalHitCountCollector.java (props changed)
> lucene/dev/branches/branch_4x/lucene/demo/ (props changed)
> lucene/dev/branches/branch_4x/lucene/expressions/ (props changed)
> lucene/dev/branches/branch_4x/lucene/facet/ (props changed)
> lucene/dev/branches/branch_4x/lucene/grouping/ (props changed)
> lucene/dev/branches/branch_4x/lucene/highlighter/ (props changed)
> lucene/dev/branches/branch_4x/lucene/ivy-settings.xml (props
> changed)
> lucene/dev/branches/branch_4x/lucene/ivy-versions.properties (props
> changed)
> lucene/dev/branches/branch_4x/lucene/join/ (props changed)
> lucene/dev/branches/branch_4x/lucene/licenses/ (props changed)
> lucene/dev/branches/branch_4x/lucene/memory/ (props changed)
> lucene/dev/branches/branch_4x/lucene/misc/ (props changed)
> lucene/dev/branches/branch_4x/lucene/module-build.xml (props
> changed)
> lucene/dev/branches/branch_4x/lucene/queries/ (props changed)
>
> lucene/dev/branches/branch_4x/lucene/queries/src/test/org/apache/lucen
> e/queries/function/TestFunctionQuerySort.java (props changed)
> lucene/dev/branches/branch_4x/lucene/queryparser/ (props changed)
> lucene/dev/branches/branch_4x/lucene/replicator/ (props changed)
> lucene/dev/branches/branch_4x/lucene/sandbox/ (props changed)
> lucene/dev/branches/branch_4x/lucene/site/ (props changed)
> lucene/dev/branches/branch_4x/lucene/spatial/ (props changed)
> lucene/dev/branches/branch_4x/lucene/suggest/ (props changed)
> lucene/dev/branches/branch_4x/lucene/test-framework/ (props
> changed)
> lucene/dev/branches/branch_4x/lucene/tools/ (props changed)
> lucene/dev/branches/branch_4x/solr/ (props changed)
> lucene/dev/branches/branch_4x/solr/CHANGES.txt (props changed)
> lucene/dev/branches/branch_4x/solr/LICENSE.txt (props changed)
> lucene/dev/branches/branch_4x/solr/NOTICE.txt (props changed)
> lucene/dev/branches/branch_4x/solr/README.txt (props changed)
> lucene/dev/branches/branch_4x/solr/SYSTEM_REQUIREMENTS.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/build.xml (props changed)
> lucene/dev/branches/branch_4x/solr/cloud-dev/ (props changed)
> lucene/dev/branches/branch_4x/solr/common-build.xml (props
> changed)
> lucene/dev/branches/branch_4x/solr/contrib/ (props changed)
> lucene/dev/branches/branch_4x/solr/core/ (props changed)
>
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/BasicF
> unctionalityTest.java
>
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/core/T
> estConfig.java (props changed)
>
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/handle
> r/JsonLoaderTest.java
>
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/search
> /TestSolr4Spatial.java
> lucene/dev/branches/branch_4x/solr/example/ (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/ (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/httpclient-LICENSE-ASL.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/httpclient-NOTICE.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/httpcore-LICENSE-ASL.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/httpcore-NOTICE.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/httpmime-LICENSE-ASL.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/licenses/httpmime-NOTICE.txt
> (props changed)
> lucene/dev/branches/branch_4x/solr/scripts/ (props changed)
> lucene/dev/branches/branch_4x/solr/site/ (props changed)
> lucene/dev/branches/branch_4x/solr/solrj/ (props changed)
> lucene/dev/branches/branch_4x/solr/test-framework/ (props changed)
> lucene/dev/branches/branch_4x/solr/webapp/ (props changed)
>
> Modified:
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/BasicF
> unctionalityTest.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/core/sr
> c/test/org/apache/solr/BasicFunctionalityTest.java?rev=1564834&r1=156483
> 3&r2=1564834&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/BasicF
> unctionalityTest.java (original)
> +++
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/Bas
> +++ icFunctionalityTest.java Wed Feb 5 17:11:27 2014
> @@ -346,7 +346,7 @@ public class BasicFunctionalityTest exte
> }
>
>
> - @Test @Ignore("Please fix me!")
> + @Test
> public void testClientErrorOnMalformedNumbers() throws Exception {
>
> final String BAD_VALUE = "NOT_A_NUMBER";
>
> Modified:
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/handle
> r/JsonLoaderTest.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/core/sr
> c/test/org/apache/solr/handler/JsonLoaderTest.java?rev=1564834&r1=1564
> 833&r2=1564834&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/handle
> r/JsonLoaderTest.java (original)
> +++
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/han
> +++ dler/JsonLoaderTest.java Wed Feb 5 17:11:27 2014
> @@ -31,7 +31,6 @@ import org.apache.solr.update.DeleteUpda import
> org.apache.solr.update.processor.BufferingRequestProcessor;
> import org.junit.BeforeClass;
> import org.junit.Test;
> -import org.junit.Ignore;
> import org.xml.sax.SAXException;
>
> import java.math.BigDecimal;
> @@ -392,7 +391,7 @@ public class JsonLoaderTest extends Solr
> }
>
>
> - @Test @Ignore("Please fix me!")
> + @Test
> public void testAddBigIntegerValueToTrieField() throws Exception {
> // Adding a BigInteger to a long field should fail
> // BigInteger.longValue() returns only the low-order 64 bits.
>
> Modified:
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/search
> /TestSolr4Spatial.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/core/sr
> c/test/org/apache/solr/search/TestSolr4Spatial.java?rev=1564834&r1=15648
> 33&r2=1564834&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/search
> /TestSolr4Spatial.java (original)
> +++
> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/sea
> +++ rch/TestSolr4Spatial.java Wed Feb 5 17:11:27 2014
> @@ -35,7 +35,6 @@ import org.apache.solr.util.SpatialUtils import
> org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; -import
> org.junit.Ignore;
>
> import java.text.ParseException;
> import java.util.Arrays;
> @@ -72,7 +71,7 @@ public class TestSolr4Spatial extends So
> assertU(commit());
> }
>
> - @Test @Ignore("Please fix me!")
> + @Test
> public void testBadShapeParse400() {
> assertQEx(null, req(
> "fl", "id," + fieldName, "q", "*:*", "rows", "1000",
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org