You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Christian Posta (JIRA)" <ji...@apache.org> on 2012/10/23 00:00:12 UTC
[jira] [Created] (AMQ-4123) Improve MQTT Inactivity Monitoring
Christian Posta created AMQ-4123:
------------------------------------
Summary: Improve MQTT Inactivity Monitoring
Key: AMQ-4123
URL: https://issues.apache.org/jira/browse/AMQ-4123
Project: ActiveMQ
Issue Type: Bug
Components: Message Store, MQTT
Reporter: Christian Posta
Priority: Minor
* Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
* MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
* What to do when user explicitly turns Inactivity Monitor off?
* Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482784#comment-13482784 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
There's some karma needed to edit the Wiki.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483209#comment-13483209 ]
Christian Posta commented on AMQ-4123:
--------------------------------------
Ah, very nice with the waitFor(condition)... thanks!
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Posta reassigned AMQ-4123:
------------------------------------
Assignee: Christian Posta
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Assignee: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482615#comment-13482615 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
I'm not opposed to you adding in the conversion to a KeepAliveInfo, just wanted to note that its not altogether necessary.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482797#comment-13482797 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
Changes look good, not sure on the tests, will have to think on that.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482600#comment-13482600 ]
Christian Posta commented on AMQ-4123:
--------------------------------------
Tim,
I considered that too. However, the PINGREQ/PINGRESP are frames that are part of the contract/spec that determine whether a connection should stay open (insofar as I understand). So if the PINGREQ frame isn't treated specifically in the InactivityMonitor, then it's only counting whether or not more data has come in over the wire. But in that case, you could just send in random data not related to the MQTT spec and that alone would keep the InactivityMonitor alive... Which isn't necessarily desired?
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482777#comment-13482777 ]
Christian Posta commented on AMQ-4123:
--------------------------------------
So I went without the KeepAliveInfo object.
Also fixed the MQTTTests that were broken, added more around inactivity monitor, added default keep-alive for server side, implemented a grace-period for keep-alive.
Tim, if you could review just to sanity check, that would be great.
The tests around inactivity monitor are not the best (uses some Thread.sleep() calls to get the inactivity monitor to hang). If you can think of a better way, I'm all ears.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Posta resolved AMQ-4123.
----------------------------------
Resolution: Fixed
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482614#comment-13482614 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
Well technically speaking you could do that on any of the transports, but hopefully that random data would generate a marshaling exception and shutdown the connection.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486348#comment-13486348 ]
Christian Posta commented on AMQ-4123:
--------------------------------------
Tim,
Yes. Was waiting to assign it to myself, but haven't heard back from Hiram on my Jira access. I can mark it resolved
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Posta updated AMQ-4123:
---------------------------------
Component/s: (was: Message Store)
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT
> Reporter: Christian Posta
> Priority: Minor
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482779#comment-13482779 ]
Christian Posta commented on AMQ-4123:
--------------------------------------
PS... there are some docs I would like to update on the wiki around MQTT. I still don't seem to have access to assign things to myself in jira, and I don't see any options to update the wiki. Is that another permission?
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish updated AMQ-4123:
------------------------------
Component/s: Transport
Affects Version/s: 5.7.0
Fix Version/s: 5.8.0
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483205#comment-13483205 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
Updated the test case to remove the hard sleeps
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482595#comment-13482595 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
The MQTTInactivityMonitor doesn't really need to get an KeepAliveInfo so long as the receiveCounter value is updated correctly. I committed a fix today that should make that happen now in the NIO and NIOSSL transports so all should be fine there.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486339#comment-13486339 ]
Timothy Bish commented on AMQ-4123:
-----------------------------------
@Christian, is this complete now?
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4123) Improve MQTT Inactivity Monitoring
Posted by "Christian Posta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482628#comment-13482628 ]
Christian Posta commented on AMQ-4123:
--------------------------------------
Yah, I hear ya. Im on the fence now too. If we use the KeepAliveInfo, then it ties the PINGREQ/RESP to the InactivityMonitor. As it is right now, when the MQTTProtocolConverter sees a PINGREQ, it responds right away with a PINGRESP regardless of whether there is an InactivityMonitor (transport.useInactivityMonitor=false).
On the other hand, the InactivityMonitor is the heart-beating on the server side and the PINGREQ/RESP is the contract. My instincts say to make the PINGREQ/RESP explicit in the implementation.
idk yet. i'll run my proposed changes by you before I commit.
> Improve MQTT Inactivity Monitoring
> ----------------------------------
>
> Key: AMQ-4123
> URL: https://issues.apache.org/jira/browse/AMQ-4123
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT, Transport
> Affects Versions: 5.7.0
> Reporter: Christian Posta
> Priority: Minor
> Fix For: 5.8.0
>
>
> * Keep Alive should be 1.5 * the keep alive value specified by client (the grace period described in spec: http://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html)
> * MQTTInactivityMonitor checking for KeepAliveInfo in the onCommand, but it can never get a KeepAliveInfo as it is
> * What to do when user explicitly turns Inactivity Monitor off?
> * Should there be defaults to close potentially dead connections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira