[GitHub] [superset] stephenLYZ commented on a diff in pull request #20011: fix(chart & heatmap): make to fix that y label is rendering out of bounds

[GitBox <gi...@apache.org>]

stephenLYZ commented on code in PR #20011:
URL: https://github.com/apache/superset/pull/20011#discussion_r872622278


##########
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/Heatmap.js:
##########
@@ -121,6 +121,7 @@ function Heatmap(element, props) {
     let longestY = 1;
 
     records.forEach(datum => {
+      if (typeof datum.y === 'number') pixelsPerCharY = 7;

Review Comment:
   Actually It is implemented using d3 and the implementation does not seem elegant.  Let's migrate to echarts later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org