[GitHub] [superset] villebro commented on a change in pull request #14932: chore: Improves the native filters UI/UX - iteration 6

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #14932:
URL: https://github.com/apache/superset/pull/14932#discussion_r643674284



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -423,6 +425,14 @@ const FiltersConfigForm = (
     ({ value }) => value === filterToEdit?.cascadeParentIds[0],
   );
 
+  const hasParentFilter = !!parentFilter;
+
+  const hasPreFilter =
+    !!filterToEdit?.adhoc_filters || !!filterToEdit?.time_range;
+
+  const hasSorting =
+    typeof filterToEdit?.controlValues?.sortAscending === 'boolean';

Review comment:
       Not important for iteration 6, but it could be a good idea to add TODOs here, to make it easier to formulate a plan for automating this based on control properties in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org