You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "elguardian (via GitHub)" <gi...@apache.org> on 2024/04/22 08:42:11 UTC
[PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
elguardian opened a new pull request, #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478
issue: https://github.com/apache/incubator-kie-issues/issues/1103
move tests and bpmn2 compilation of v7 legacy runtime. the goal is not affect the current status of tests while allow working on migrating tests and features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580527679
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class XXX extends AbstractProcess<Model> {
Review Comment:
it is just a template. so it does not really matter, it could be whatever
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/test/resources/unit/project/src/main/bpmn/BPMN2-MinimalProcess.bak:
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1581049702
##########
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/LambdaSubProcessNodeVisitor.java:
##########
@@ -143,15 +149,22 @@ private BlockStmt bind(ModelMetaData subProcessModel) {
}
private BlockStmt createInstance(SubProcessNode subProcessNode, ProcessMetaData metadata) {
-
+ // return app.get(Processes.class).<Model>processById(subprocessId).createInstance(model);
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580527476
##########
jbpm/jbpm-tests/src/test/bpmn/org/jbpm/bpmn2/flow/BPMN2-MultipleProcessInOneFile.bpmn2:
##########
@@ -6,9 +6,9 @@
xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.omg.org/spec/BPMN/20100524/MODEL BPMN20.xsd"
- xmlns:tns="http://www.example.org/EvaluationExample">
+ xmlns:tns="http://www.jboss.org/drools">
Review Comment:
yeah I know for know it is what we have and what the parser needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1581047999
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/test/resources/unit/project/src/main/bpmn/BPMN2-MinimalProcess.bak:
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
removed
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class XXX extends AbstractProcess<Model> {
Review Comment:
replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian merged PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580527211
##########
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/LambdaSubProcessNodeVisitor.java:
##########
@@ -143,15 +149,22 @@ private BlockStmt bind(ModelMetaData subProcessModel) {
}
private BlockStmt createInstance(SubProcessNode subProcessNode, ProcessMetaData metadata) {
-
+ // return app.get(Processes.class).<Model>processById(subprocessId).createInstance(model);
Review Comment:
sometimes it is really difficult to know exactly what expression you are trying to build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1581106658
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class ThisIsJustTemplate extends AbstractProcess<Model> {
+
+
+ public static org.kie.kogito.process.Process<Model> newProcess(Application application) {
+ return new XXX(application.config().get(ProcessConfig.class), application);
Review Comment:
ThisIsJustTemplate update missing
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class ThisIsJustTemplate extends AbstractProcess<Model> {
+
+
+ public static org.kie.kogito.process.Process<Model> newProcess(Application application) {
+ return new XXX(application.config().get(ProcessConfig.class), application);
+ }
+
+ public XXX(ProcessConfig processConfig, Application application) {
Review Comment:
ThisIsJustTemplate update missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580684091
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/test/resources/unit/project/src/main/bpmn/BPMN2-MinimalProcess.bak:
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
usually bak file are auto generated on save by some editors... maybe clarify that this is not the case somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1579769274
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class XXX extends AbstractProcess<Model> {
Review Comment:
XXXX?
##########
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/LambdaSubProcessNodeVisitor.java:
##########
@@ -143,15 +149,22 @@ private BlockStmt bind(ModelMetaData subProcessModel) {
}
private BlockStmt createInstance(SubProcessNode subProcessNode, ProcessMetaData metadata) {
-
+ // return app.get(Processes.class).<Model>processById(subprocessId).createInstance(model);
Review Comment:
why comment here?
##########
kogito-build/kogito-dependencies-bom/pom.xml:
##########
@@ -122,15 +122,17 @@
<version.org.slf4j>2.0.6</version.org.slf4j>
<version.maven>3.9.3</version.maven>
+ <version.maven.project>2.2.1</version.maven.project>
<version.maven.plugin>3.7.1</version.maven.plugin>
<version.maven.invoker>3.2.0</version.maven.invoker>
-
+ <version.maven.plugin.testing.harness>4.0.0-alpha-2</version.maven.plugin.testing.harness>
<version.plexus>2.1.0</version.plexus>
<version.plexus.classworld>2.6.0</version.plexus.classworld>
<!-- see: https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html#parallel-test-execution-and-single-thread-execution -->
<version.com.github.stephenc.jcip>1.0-1</version.com.github.stephenc.jcip>
<version.black.ninia>4.2.0</version.black.ninia>
+ <version.com.google.collections>1.0</version.com.google.collections>
Review Comment:
note: this might be impacted by Quarkus upgrade
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/test/resources/unit/project/src/main/bpmn/BPMN2-MinimalProcess.bak:
##########
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
is this file needed?
##########
jbpm/jbpm-tests/src/test/bpmn/org/jbpm/bpmn2/flow/BPMN2-MultipleProcessInOneFile.bpmn2:
##########
@@ -6,9 +6,9 @@
xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.omg.org/spec/BPMN/20100524/MODEL BPMN20.xsd"
- xmlns:tns="http://www.example.org/EvaluationExample">
+ xmlns:tns="http://www.jboss.org/drools">
Review Comment:
eventually we need change this to apache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580682124
##########
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/LambdaSubProcessNodeVisitor.java:
##########
@@ -143,15 +149,22 @@ private BlockStmt bind(ModelMetaData subProcessModel) {
}
private BlockStmt createInstance(SubProcessNode subProcessNode, ProcessMetaData metadata) {
-
+ // return app.get(Processes.class).<Model>processById(subprocessId).createInstance(model);
Review Comment:
ohh I got it; maybe add a explanation that this is the expected expression being created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580686538
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class XXX extends AbstractProcess<Model> {
Review Comment:
what about: ThisIsJustTemplate or something like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#issuecomment-2069147894
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3478/1/display/redirect
**Test results:**
- PASSED: 3260
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3478/1/testReport/org.kie.kogito.quarkus.jbpm/OrdersProcessIT/testOrdersRest/">org.kie.kogito.quarkus.jbpm.OrdersProcessIT.testOrdersRest</a></summary>
1 expectation failed.<br/>Expected status code <201> but was <500>.<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1580527916
##########
kogito-build/kogito-dependencies-bom/pom.xml:
##########
@@ -122,15 +122,17 @@
<version.org.slf4j>2.0.6</version.org.slf4j>
<version.maven>3.9.3</version.maven>
+ <version.maven.project>2.2.1</version.maven.project>
<version.maven.plugin>3.7.1</version.maven.plugin>
<version.maven.invoker>3.2.0</version.maven.invoker>
-
+ <version.maven.plugin.testing.harness>4.0.0-alpha-2</version.maven.plugin.testing.harness>
<version.plexus>2.1.0</version.plexus>
<version.plexus.classworld>2.6.0</version.plexus.classworld>
<!-- see: https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html#parallel-test-execution-and-single-thread-execution -->
<version.com.github.stephenc.jcip>1.0-1</version.com.github.stephenc.jcip>
<version.black.ninia>4.2.0</version.black.ninia>
+ <version.com.google.collections>1.0</version.com.google.collections>
Review Comment:
that is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3478:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1581185138
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class ThisIsJustTemplate extends AbstractProcess<Model> {
+
+
+ public static org.kie.kogito.process.Process<Model> newProcess(Application application) {
+ return new XXX(application.config().get(ProcessConfig.class), application);
Review Comment:
replaced
##########
jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jbpm.process.codegen;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.drools.core.util.KieFunctions;
+
+import org.jbpm.process.core.context.variable.Variable;
+import org.jbpm.process.core.context.variable.VariableScope;
+import org.jbpm.ruleflow.core.RuleFlowProcessFactory;
+import org.jbpm.workflow.core.WorkflowProcess;
+import org.kie.api.definition.process.Process;
+import org.kie.api.runtime.process.WorkflowProcessInstance;
+import org.kie.kogito.Application;
+import org.kie.kogito.Model;
+import org.kie.kogito.correlation.CompositeCorrelation;
+import org.kie.kogito.process.ProcessConfig;
+import org.kie.kogito.process.ProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcess;
+import org.kie.kogito.process.bpmn2.BpmnProcessInstance;
+import org.kie.kogito.process.bpmn2.BpmnProcesses;
+import org.kie.kogito.process.bpmn2.BpmnVariables;
+import org.kie.kogito.process.impl.AbstractProcess;
+
+public class ThisIsJustTemplate extends AbstractProcess<Model> {
+
+
+ public static org.kie.kogito.process.Process<Model> newProcess(Application application) {
+ return new XXX(application.config().get(ProcessConfig.class), application);
+ }
+
+ public XXX(ProcessConfig processConfig, Application application) {
Review Comment:
replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org