You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/07/24 06:06:11 UTC

[GitHub] [spark] beliefer opened a new pull request, #42121: [SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars

beliefer opened a new pull request, #42121:
URL: https://github.com/apache/spark/pull/42121

   ### What changes were proposed in this pull request?
   https://github.com/apache/spark/pull/41932 try to add test case for connect, then we found the maven build failure based on the bug discussed at https://github.com/apache/spark/pull/41932#discussion_r1266118099
   
   After some communication, @cloud-fan and @zhengruifeng suggested to ignore the test case for connect.
   So I commit this PR to fix the bug.
   
   
   ### Why are the changes needed?
   Fix the bug that `SparkConnectServerUtils` generated incorrect parameters for jars.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Just update the inner implementation.
   
   
   ### How was this patch tested?
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #42121: [SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42121:
URL: https://github.com/apache/spark/pull/42121#issuecomment-1647759875

   @LuciferYang @HyukjinKwon Thank you !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #42121: [SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42121:
URL: https://github.com/apache/spark/pull/42121#issuecomment-1647746970

   Merged into master and branch-3.5. Thanks @HyukjinKwon @beliefer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang closed pull request #42121: [SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #42121: [SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars
URL: https://github.com/apache/spark/pull/42121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #42121: [SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42121:
URL: https://github.com/apache/spark/pull/42121#issuecomment-1647290472

   ping @LuciferYang cc @HyukjinKwon @zhengruifeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org