You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/04/12 10:00:50 UTC

Review Request 46075: Update docs to reflect /containers endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Docs are updated using support/generate-endpoint-help.py.


Diffs
-----

  docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
  docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
  docs/endpoints/slave/containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/46075/diff/


Testing
-------


Thanks,

Jay Guo


Re: Review Request 46075: Update docs to reflect /containers endpoint.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/#review128361
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45014, 46075]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 12, 2016, 9:34 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46075/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 9:34 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docs are updated using support/generate-endpoint-help.py.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
>   docs/endpoints/slave/containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Re: Review Request 46075: Update docs to reflect /containers endpoint.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/#review129284
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45014, 46075]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 18, 2016, 3:39 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46075/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docs are updated using support/generate-endpoint-help.py.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
>   docs/endpoints/slave/containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Re: Review Request 46075: Update docs to reflect /containers endpoint.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/#review130115
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 18, 2016, 3:39 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46075/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docs are updated using support/generate-endpoint-help.py.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
>   docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
>   docs/endpoints/slave/containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Re: Review Request 46075: Update docs to reflect /containers endpoint.

Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/
-----------------------------------------------------------

(Updated April 18, 2016, 3:39 a.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Docs are updated using support/generate-endpoint-help.py.


Diffs (updated)
-----

  docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
  docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
  docs/endpoints/slave/containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/46075/diff/


Testing
-------


Thanks,

Jay Guo


Re: Review Request 46075: Update docs to reflect /containers endpoint.

Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/
-----------------------------------------------------------

(Updated April 12, 2016, 9:34 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Change help text to include ip_addresses instead.


Repository: mesos


Description
-------

Docs are updated using support/generate-endpoint-help.py.


Diffs (updated)
-----

  docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
  docs/endpoints/monitor/statistics.json.md 1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
  docs/endpoints/slave/containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/46075/diff/


Testing
-------


Thanks,

Jay Guo