[GitHub] [datasketches-java] jmalkin commented on pull request #375: Add a nullSafe mode in ArrayOfStringsSerDe

[GitBox <gi...@apache.org>]

jmalkin commented on pull request #375:
URL: https://github.com/apache/datasketches-java/pull/375#issuecomment-978235805


   There are some sketches where we don't allow `null` as input, but maybe that's not a concern since this would have nothing to do.
   
   One potential issue is that it'll introduce an outright incompatibility with C++, where the provided serde uses unsigned values. It seems fairly unlikely that anyone has produced serialized images with string lengths >= 2^31, but it might be better to use a separate null-aware class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org