You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey A. Ivanov (JIRA)" <ji...@apache.org> on 2006/12/22 15:05:23 UTC
[jira] Created: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
[classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
------------------------------------------------------------------------------------------------------
Key: HARMONY-2855
URL: http://issues.apache.org/jira/browse/HARMONY-2855
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexey A. Ivanov
Priority: Minor
javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464697 ]
Mark Hindess commented on HARMONY-2855:
---------------------------------------
Please stop mixing patches for the fixes with patches for other things - like serialization and compiler warnings. I had to manually apply parts of the patch but really they were irrelevant to the fix. Committers might be put of applying the fix if the patch fails so keep it to just what is relevant and create separate JIRA for the other issues.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: https://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2855-BasicSliderUI.patch, H2855-BasicSliderUITest.patch, HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2855?page=all ]
Alexey A. Ivanov updated HARMONY-2855:
--------------------------------------
Attachment: H2855-BasicSliderUI.patch
The fix: I've added the corresponding condition where IllegalComponentStateException is thrown.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: http://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2855-BasicSliderUI.patch, H2855-BasicSliderUITest.patch, HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2855?page=comments#action_12460961 ]
Alexey A. Ivanov commented on HARMONY-2855:
-------------------------------------------
It's better to apply the patch for tests before applying test patch from HARMONY-2879.
The patch to code is incorporated in code fix patch from HARMONY-2879.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: http://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2855-BasicSliderUI.patch, H2855-BasicSliderUITest.patch, HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-2855.
-----------------------------------
Resolution: Fixed
Assignee: Mark Hindess
Applied patches in r496250. Please confirm they have been applied as expected.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: https://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: H2855-BasicSliderUI.patch, H2855-BasicSliderUITest.patch, HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey A. Ivanov closed HARMONY-2855.
-------------------------------------
Everything's fine.
Thank you, Mark.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: https://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Mark Hindess
> Priority: Minor
> Attachments: H2855-BasicSliderUI.patch, H2855-BasicSliderUITest.patch, HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2855?page=all ]
Alexey A. Ivanov updated HARMONY-2855:
--------------------------------------
Attachment: HTest2855.java
Simple application which shows the issue.
--- Harmony Output ---
passed 1
failed 2
failed 3
java.lang.ClassCastException: javax.swing.JButton incompatible with javax.swing.JSlider
at javax.swing.plaf.basic.BasicSliderUI.uninstallUI(BasicSliderUI.java:422)
at HTest2855.main(HTest2855.java:59)
failed 4
------
--- RI Output ---
passed 1
java.awt.IllegalComponentStateException: javax.swing.plaf.basic.BasicSliderUI@2bb0d7 was asked to deinstall() javax.swing.JSlider[,0,0,0x0,invalid,alignmentX=0.0,alignmentY=0.0,border=,flags=296,maximumSize=,minimumSize=,preferredSize=,isInverted=false,majorTickSpacing=0,minorTickSpacing=0,orientation=HORIZONTAL,paintLabels=false,paintTicks=false,paintTrack=true,snapToTicks=false,snapToValue=true] when it only knows about null.
at javax.swing.plaf.basic.BasicSliderUI.uninstallUI(BasicSliderUI.java:148)
at HTest2855.main(HTest2855.java:29)
passed 2
java.awt.IllegalComponentStateException: javax.swing.plaf.basic.BasicSliderUI@2bc49b was asked to deinstall() javax.swing.JSlider[,0,0,0x0,invalid,alignmentX=0.0,alignmentY=0.0,border=,flags=296,maximumSize=,minimumSize=,preferredSize=,isInverted=false,majorTickSpacing=0,minorTickSpacing=0,orientation=HORIZONTAL,paintLabels=false,paintTicks=false,paintTrack=true,snapToTicks=false,snapToValue=true] when it only knows about null.
at javax.swing.plaf.basic.BasicSliderUI.uninstallUI(BasicSliderUI.java:148)
at HTest2855.main(HTest2855.java:44)
passed 3
java.awt.IllegalComponentStateException: javax.swing.plaf.basic.BasicSliderUI@2bcf5a was asked to deinstall() javax.swing.JButton[,0,0,0x0,invalid,alignmentX=0.0,alignmentY=0.5,border=javax.swing.plaf.BorderUIResource$CompoundBorderUIResource@2bd38a,flags=296,maximumSize=,minimumSize=,preferredSize=,defaultIcon=,disabledIcon=,disabledSelectedIcon=,margin=javax.swing.plaf.InsetsUIResource[top=2,left=14,bottom=2,right=14],paintBorder=true,paintFocus=true,pressedIcon=,rolloverEnabled=true,rolloverIcon=,rolloverSelectedIcon=,selectedIcon=,text=,defaultCapable=true] when it only knows about null.
at javax.swing.plaf.basic.BasicSliderUI.uninstallUI(BasicSliderUI.java:148)
at HTest2855.main(HTest2855.java:59)
passed 4
------
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: http://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2855) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.uninstallUI should throw
IllegalComponentStateException
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2855?page=all ]
Alexey A. Ivanov updated HARMONY-2855:
--------------------------------------
Attachment: H2855-BasicSliderUITest.patch
Regression tests.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2855
> URL: http://issues.apache.org/jira/browse/HARMONY-2855
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2855-BasicSliderUITest.patch, HTest2855.java
>
>
> javax.swing.plaf.basic.BasicSliderUI.uninstallUI should throw IllegalComponentStateException where the instance passed to uninstallUI does not coincide with the instance of JSlider with which the UI is associated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira