You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "liang3zy22 (via GitHub)" <gi...@apache.org> on 2023/04/04 04:51:38 UTC

[GitHub] [spark] liang3zy22 opened a new pull request, #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

liang3zy22 opened a new pull request, #40657:
URL: https://github.com/apache/spark/pull/40657

   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING".
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   The original name just a number, update it to a informal name.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   Added a test case in StringExpressionsSuite. The test case used checkError to check the raised Exception is as expected. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL"

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1158119936


##########
sql/core/src/test/scala/org/apache/spark/sql/UrlFunctionsSuite.scala:
##########
@@ -67,6 +69,19 @@ class UrlFunctionsSuite extends QueryTest with SharedSparkSession {
         "inva lid://user:pass@host/file;param?query;p2",
         Row(null, null, null, null, null, null, null, null, null))
     }
+
+    withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
+      val url = "inva lid://user:pass@host/file;param?query;p2"
+      checkError(
+        exception = intercept[SparkException] {
+               sql(s"SELECT parse_url('$url', 'HOST')").collect()

Review Comment:
   Could you fix indentation here, see https://github.com/databricks/scala-style-guide#spacing-and-indentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] itholic commented on a diff in pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1156754485


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1839,7 +1840,18 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
       }.getMessage
       assert(msg.contains("Find an invalid url string"))
     }
-    withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+    withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
+            checkError(exception = intercept[SparkIllegalArgumentException]{
+              evaluateWithoutCodegen(
+             ParseUrl(Seq("https://a.b.c/index.php?params1=a|b&params2=x", "HOST")))

Review Comment:
   Can we make `"https://a.b.c/index.php?params1=a|b&params2=x"` as variable and reuse here and there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1496094989

   @liang3zy22 You need to run an action to trigger the execution exception like:
   ```scala
       withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
         val url = "inva lid://user:pass@host/file;param?query;p2"
         checkError(
           exception = intercept[SparkException] {
             sql(s"SELECT parse_url('$url', 'HOST')").collect()
           }.getCause.asInstanceOf[SparkThrowable],
           errorClass = "INVALID_URL",
           parameters = Map(
             "url" -> url,
             "ansiConfig" -> toSQLConf(SQLConf.ANSI_ENABLED.key)))
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1158145447


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,22 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {

Review Comment:
   I care mostly of the case when the ANSI mode is enabled. Let's deduplicate the code for the case, and check the error in the end-to-end case only. The goal is to cover the error class by a test.
   
   > There is already one test case in UrlFunctionSuite with ANSI disabled, using df.selectExpr("parse_url()") method.
   
   ok. If it checks an invalid url.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL"

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1158119096


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,22 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {

Review Comment:
   This test duplicates the check in `UrlFunctionsSuite`, actually. Let's move it to `UrlFunctionsSuite`, and use `parse_url()` in ANSI/non-ANSI modes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1498579830

   @liang3zy22 Do you have an account at https://issues.apache.org/ ? I would like to resolve it and assign it to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liang3zy22 commented on a diff in pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "liang3zy22 (via GitHub)" <gi...@apache.org>.
liang3zy22 commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1158135907


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,22 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {

Review Comment:
   You mean add test case in UrlFunctionsSuite to use sql("SELECT parse_url(...)") command with ANSI disabled? There is already one test case in UrlFunctionSuite with ANSI disabled, using df.selectExpr("parse_url()") method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1156982555


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,28 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {
+    val url = "https://a.b.c/index.php?params1=a|b&params2=x"
     withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
       val msg = intercept[IllegalArgumentException] {
         evaluateWithoutCodegen(
-          ParseUrl(Seq("https://a.b.c/index.php?params1=a|b&params2=x", "HOST")))
+          ParseUrl(Seq(url, "HOST")))
       }.getMessage
       assert(msg.contains("Find an invalid url string"))
     }
-    withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+    withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
+            checkError(exception = intercept[SparkIllegalArgumentException]{
+              evaluateWithoutCodegen(
+             ParseUrl(Seq(url, "HOST")))

Review Comment:
   Could you trigger the error from user code, please. For example `sql("select parse_url(...)")`



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1062,6 +1062,11 @@
     ],
     "sqlState" : "42604"
   },
+  "INVALID_URL_STRING" : {

Review Comment:
   Could you make it shorter `INVALID_URL`, please. The word `_STRING` doesn't bring any additional info, IMHO.



##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,28 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {
+    val url = "https://a.b.c/index.php?params1=a|b&params2=x"
     withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
       val msg = intercept[IllegalArgumentException] {
         evaluateWithoutCodegen(
-          ParseUrl(Seq("https://a.b.c/index.php?params1=a|b&params2=x", "HOST")))
+          ParseUrl(Seq(url, "HOST")))
       }.getMessage
       assert(msg.contains("Find an invalid url string"))
     }
-    withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+    withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
+            checkError(exception = intercept[SparkIllegalArgumentException]{
+              evaluateWithoutCodegen(
+             ParseUrl(Seq(url, "HOST")))
+            },
+              errorClass = "INVALID_URL_STRING",

Review Comment:
   Please, fix indentations around.



##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,28 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {
+    val url = "https://a.b.c/index.php?params1=a|b&params2=x"
     withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
       val msg = intercept[IllegalArgumentException] {
         evaluateWithoutCodegen(
-          ParseUrl(Seq("https://a.b.c/index.php?params1=a|b&params2=x", "HOST")))
+          ParseUrl(Seq(url, "HOST")))
       }.getMessage
       assert(msg.contains("Find an invalid url string"))
     }

Review Comment:
   Could you remove this since it duplicates the check below.



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1062,6 +1062,11 @@
     ],
     "sqlState" : "42604"
   },
+  "INVALID_URL_STRING" : {
+    "message" : [
+      "Find an invalid url string <url>. If necessary set <ansiConfig> to false to bypass this error."

Review Comment:
   Please, quote `false`:
   ```suggestion
         "The url is invalid: <url>. If necessary set <ansiConfig> to \"false\" to bypass this error."
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1498595729

   +1, LGTM. Merging to master.
   Thank you, @liang3zy22 and @itholic for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liang3zy22 commented on pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "liang3zy22 (via GitHub)" <gi...@apache.org>.
liang3zy22 commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1498600699

   @MaxGekk and @itholic  , thanks for your patient review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`
URL: https://github.com/apache/spark/pull/40657


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liang3zy22 commented on a diff in pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

Posted by "liang3zy22 (via GitHub)" <gi...@apache.org>.
liang3zy22 commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1156792695


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1839,7 +1840,18 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
       }.getMessage
       assert(msg.contains("Find an invalid url string"))
     }
-    withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+    withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
+            checkError(exception = intercept[SparkIllegalArgumentException]{
+              evaluateWithoutCodegen(
+             ParseUrl(Seq("https://a.b.c/index.php?params1=a|b&params2=x", "HOST")))

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liang3zy22 commented on pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

Posted by "liang3zy22 (via GitHub)" <gi...@apache.org>.
liang3zy22 commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1496046743

   @MaxGekk , I have updated the PR for all your review except the "Could you trigger the error from user code, please. For example sql("select parse_url(...)")".
   I can't use sql function in StringExpressionsSuite.scala, don't know how to import the sql function. 
   I have tried in UrlFunctionsSuite.scala using sql function. The test result reported:
   ```
   [info] - url parse_url function *** FAILED *** (3 seconds, 922 milliseconds)
   [info]   Expected exception org.apache.spark.SparkIllegalArgumentException to be thrown, but no exception was thrown (UrlFunctionsSuite.scala:75)
   ```  
   
   Actually I firstly added test case in UrlFunctionSuite like I do now.scala to try to get the error, but I failed. I have tried to assign the sql code result to a variable and then call show method. The test case reported following error:
   ```
   [info] - url parse_url function *** FAILED *** (4 seconds, 65 milliseconds)
   [info]   Expected exception org.apache.spark.SparkIllegalArgumentException to be thrown, but org.apache.spark.SparkException was thrown (UrlFunctionsSuite.scala:75)
   ```
   
   Then I found StringExpressionsSuite.scala and tried in it. The error can be reproduced. So I don't know it can't be reproduced from user space or my method is wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] liang3zy22 commented on pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "liang3zy22 (via GitHub)" <gi...@apache.org>.
liang3zy22 commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1498590596

   > SPARK-42844
   
   I have. I already added comment in the JIRA issue SPRAK-42844.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1498597356

   @liang3zy22 Congratulations with your first contribution to Apache Spark!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org