[GitHub] [helix] pkuwm commented on a change in pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948#discussion_r407037079
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java
 ##########
 @@ -89,6 +94,11 @@
   private static final List<String> CLUSTER_LIST =
       ImmutableList.of("CLUSTER_1", "CLUSTER_2", "CLUSTER_3");
 
+  // For testing different MSDS endpoint configs.
+  private static final String CLUSTER_THREE = "CLUSTER_3";
+  private static final String CLUSTER_FOUR = "CLUSTER_4";
+  private static final String SLASH = "/";
 
 Review comment:
   - My initial thought was there are too many places that use slash so just wanted to make it a constant to reduce objects created.
   - `PropertyPathBuilder` doesn't cover all the cases/paths creation in this test
   - Slash does not only act as a root, but also a separator. So root does not satisfy very well.
   - Instead, I just leave the way slash is used as it is in the original code, but create a `formPath()` for my case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org