You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/04/18 01:19:03 UTC

[GitHub] [dolphinscheduler] lenboo commented on a change in pull request #5300: [Feature][JsonSplit] Fix master/worker about shellTask

lenboo commented on a change in pull request #5300:
URL: https://github.com/apache/dolphinscheduler/pull/5300#discussion_r615325046



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/builder/TaskExecutionContextBuilder.java
##########
@@ -55,11 +55,12 @@ public TaskExecutionContextBuilder buildTaskInstanceRelatedInfo(TaskInstance tas
 
     public TaskExecutionContextBuilder buildTaskDefinitionRelatedInfo(TaskDefinition taskDefinition) {
         int timeoutSeconds = taskDefinition.getTimeout() * SEC_2_MINUTES_TIME_UNIT;
-        if (timeoutSeconds >= Integer.MAX_VALUE) {
+        if (timeoutSeconds == 0) {

Review comment:
       if a==0 then  a=max_value？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org