You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by NickManley <gi...@git.apache.org> on 2016/01/24 08:38:32 UTC
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
GitHub user NickManley opened a pull request:
https://github.com/apache/commons-lang/pull/122
Add method to DiffBuilder to allow appending from a DiffResult.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NickManley/commons-lang appendDiffs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 9d67c28999caa4a654f607c29fb5cc363e3487c4
Author: Nick Manley <ni...@outlook.com>
Date: 2016-01-24T07:27:30Z
Add method to DiffBuilder to allow appending from a DiffResult.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/122#issuecomment-217722232
@NickManley Thanks for the pull request.
It would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira/browse/LANG/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/122#issuecomment-220404644
@NickManley Sorry I closed the wrong pull request. I meant to close #121 instead of this one.
Can you please reopen this one and close #121?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by NickManley <gi...@git.apache.org>.
Github user NickManley commented on the pull request:
https://github.com/apache/commons-lang/pull/122#issuecomment-220787760
I don't see any place on GitHub to reopen it once closed. I might need to make another pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/122#issuecomment-220845360
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/122#issuecomment-220405242
Issue to track this enhancement: https://issues.apache.org/jira/browse/LANG-1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/122#issuecomment-220791899
Thanks for opening a new pull request :) and sorry again :(.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---