You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/05 14:30:13 UTC
[GitHub] [netbeans-html4j] jtulach opened a new pull request, #48: Treat ko4j values as promises that may resolve later
jtulach opened a new pull request, #48:
URL: https://github.com/apache/netbeans-html4j/pull/48
Running
```
netbeans-html4j$ mvn -rf :browser test
```
often resulted in a failure:
```
Default:MinesTest.paintTheGridOnClick(org.netbeans.html.presenters.browser.KOScript) Time elapsed: 1.224 sec <<< FAILURE!
java.lang.AssertionError: There is ten rows in the table now: 1 expecting: 10 actual: 1
at net.java.html.json.tests.Utils.assertEquals(Utils.java:244)
at net.java.html.json.tests.MinesTest.lambda$paintTheGridOnClick$3(MinesTest.java:71)
```
this was caused by the `ko4j` JavaScript object being available sooner than initialized.
Turning `ko4j` JavaScript objects into `Promise` instances. Then we can always `resolvePromises` (of the object or of an array of objects) and only then use their values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-html4j] jtulach merged pull request #48: Treat ko4j values as promises that may resolve later
Posted by GitBox <gi...@apache.org>.
jtulach merged PR #48:
URL: https://github.com/apache/netbeans-html4j/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists