You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/03 01:35:00 UTC

[jira] [Work logged] (BEAM-2732) State tracking in Python is inefficient and has duplicated code

     [ https://issues.apache.org/jira/browse/BEAM-2732?focusedWorklogId=118550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118550 ]

ASF GitHub Bot logged work on BEAM-2732:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jul/18 01:34
            Start Date: 03/Jul/18 01:34
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request #5356: [BEAM-2732][BEAM-4028] Logging relies on StateSampler for context
URL: https://github.com/apache/beam/pull/5356#discussion_r199255236
 
 

 ##########
 File path: sdks/python/apache_beam/runners/worker/operation_specs.py
 ##########
 @@ -376,9 +376,9 @@ def __init__(self, operations, stage_name,
                step_names=None,
                original_names=None,
                name_contexts=None):
+
     self.operations = operations
     self.stage_name = stage_name
-    # TODO(BEAM-4028): Remove arguments other than name_contexts.
 
 Review comment:
   Is this obsolete?  The Jira is still open.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 118550)
    Time Spent: 16.5h  (was: 16h 20m)

> State tracking in Python is inefficient and has duplicated code
> ---------------------------------------------------------------
>
>                 Key: BEAM-2732
>                 URL: https://issues.apache.org/jira/browse/BEAM-2732
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: Major
>          Time Spent: 16.5h
>  Remaining Estimate: 0h
>
> e.g logging and metrics keep state separately. State tracking should be unified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)