[jira] [Resolved] (OAK-919) Proper handling of locks present on copied nodes

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-919.
------------------------

    Resolution: Fixed

revision 1567085: i excluded any lock-related properties from being copied to the destination. that makes the test-case pass. [~jukkaz], is there anything else that you feel should be done here?

> Proper handling of locks present on copied nodes
> ------------------------------------------------
>
>                 Key: OAK-919
>                 URL: https://issues.apache.org/jira/browse/OAK-919
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>            Assignee: Jukka Zitting
>             Fix For: 0.17
>
>
> i just had a quick look on how copy was implemented in JR-core with respect
> to locks present on the tree to be copied to a new location.
> it seems that all lock related properties are skipped and thus not copied over to the new location (which IMHO makes sense though i could not find a section in the specification explicitly defining the behavior):
> {code}
> // copy properties
>             for (Name propName : srcState.getPropertyNames()) {
> [...]
> /**
>                  * special handling required for properties with special semantics
>                  * (e.g. those defined by mix:referenceable, mix:versionable,
>                  * mix:lockable, et.al.)
>                  *
>                  * todo FIXME delegate to 'node type instance handler'
>                  */
>                 QPropertyDefinition def = ent.getApplicablePropertyDef(
>                         srcChildState.getName(), srcChildState.getType(),
>                         srcChildState.isMultiValued());
>                 if (NameConstants.MIX_LOCKABLE.equals(def.getDeclaringNodeType())) {
>                     // skip properties defined by mix:lockable
>                     continue;
>                 }
> {code}
> this is currently missing in OAK



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)