You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/11 19:17:00 UTC
[jira] [Commented] (GEODE-8349) reinstate use of SSLSocket for
cluster communication
[ https://issues.apache.org/jira/browse/GEODE-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175802#comment-17175802 ]
ASF GitHub Bot commented on GEODE-8349:
---------------------------------------
lgtm-com[bot] commented on pull request #5363:
URL: https://github.com/apache/geode/pull/5363#issuecomment-672209899
This pull request **introduces 1 alert** and **fixes 1** when merging 5b573099845881a70be91e7e3c037cdcc6b9779b into 21e26094e5178d5af1ef554448da943e07352469 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-609b7eb745dec2e7d2fa59a09e2da2bab51ed9ca)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 1 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> reinstate use of SSLSocket for cluster communication
> ----------------------------------------------------
>
> Key: GEODE-8349
> URL: https://issues.apache.org/jira/browse/GEODE-8349
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Labels: pull-request-available
>
> We've found problems with "new IO"'s SSLEngine with respect to support for TLSV1. We've also seen anomalous performance using that secure communications mechanism. The introduction of the use of the "new IO" SSLEngine was originally to 1) reduce code complexity in the org.apache.geode.internal.tcp package and 2) to set the stage for its use in client/server communications so that selectors could be used in c/s communications.
> This ticket aims to reintroduce the use of SSLSocket in cluster communications without restoring the old, poorly tested SSL code paths. The new implementation should have as good or better performance than the previous"old IO" implementation and the more recent "new IO" SSLEngine implementation as well. This should be apparent in the CI benchmark jobs.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)