You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/02/24 06:29:51 UTC

[GitHub] [pulsar] michaeljmarshall commented on pull request #19626: [fix][broker] Only send AuthChallenge when client supports it

michaeljmarshall commented on PR #19626:
URL: https://github.com/apache/pulsar/pull/19626#issuecomment-1442867314

   I did not modify the `ProxyClientCnx` or the `DirectProxyHandler` logic because in both cases, the proxy only ever sends an `AuthChallenge` when the broker sends initiates one. Because we send the broker the minimum version of the proxy and the client, the proxy will not get this message unless running with an older version of the broker.
   
   However, I think this is an edge case that this PR should cover, so I'll follow up with another commit tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org