You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/05 10:23:28 UTC
[GitHub] [inlong] healchow opened a new pull request, #5782: [INLONG-5781][Manager] Support creating consumer groups for all sinks
healchow opened a new pull request, #5782:
URL: https://github.com/apache/inlong/pull/5782
### Prepare a Pull Request
- Fixes #5781
### Motivation
Support creating consumer groups for all sinks.
### Modifications
We support the creation of multiple StreamSinks under the same InlongStreamId, which means that Sort needs to consume the data in the Topic once for each StreamSink, so a consumer group must be created for each StreamSink.
### Verifying this change
- [x] This change is a trivial rework/code cleanup without any test coverage.
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5782: [INLONG-5781][Manager] Support creating consumer groups for all sinks
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5782:
URL: https://github.com/apache/inlong/pull/5782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5782: [INLONG-5781][Manager] Support creating consumer groups for all sinks
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5782:
URL: https://github.com/apache/inlong/pull/5782#discussion_r962783642
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/InlongConsumeServiceImpl.java:
##########
@@ -82,6 +84,36 @@ public Integer save(InlongConsumeRequest request, String operator) {
return request.getId();
}
+ @Override
+ public Integer saveBySystem(InlongGroupInfo groupInfo, String topic, String consumerGroup) {
+ String groupId = groupInfo.getInlongGroupId();
+ InlongConsumeEntity exists = consumeMapper.selectExists(groupId, topic, consumerGroup);
+ if (exists != null) {
Review Comment:
Maybe it is better to return the exists id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5782: [INLONG-5781][Manager] Support creating consumer groups for all sinks
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5782:
URL: https://github.com/apache/inlong/pull/5782#discussion_r963188852
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/InlongConsumeServiceImpl.java:
##########
@@ -82,6 +84,36 @@ public Integer save(InlongConsumeRequest request, String operator) {
return request.getId();
}
+ @Override
+ public Integer saveBySystem(InlongGroupInfo groupInfo, String topic, String consumerGroup) {
+ String groupId = groupInfo.getInlongGroupId();
+ InlongConsumeEntity exists = consumeMapper.selectExists(groupId, topic, consumerGroup);
+ if (exists != null) {
Review Comment:
Good idea. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org