[hive] 03/03: HIVE-23374: QueryDisplay must be threadsafe (Zoltan Haindrich reviewed by László Bodor)

[kg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kgyrtkirk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git

commit 5c9fa2acd973c6d7cedeaf82e969714deeb601a6
Author: Zoltan Haindrich <ki...@rxd.hu>
AuthorDate: Sun May 17 06:15:33 2020 +0000

    HIVE-23374: QueryDisplay must be threadsafe (Zoltan Haindrich reviewed by László Bodor)
    
    Signed-off-by: Zoltan Haindrich <ki...@rxd.hu>
---
 ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java b/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
index 1aa5be3..0dafb00 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java
@@ -23,7 +23,6 @@ import org.apache.hadoop.hive.ql.exec.TaskResult;
 import org.apache.hadoop.hive.ql.plan.api.StageType;
 
 import java.io.IOException;
-import java.io.Serializable;
 import java.util.*;
 
 import org.apache.hadoop.mapred.Counters;
@@ -54,7 +53,7 @@ public class QueryDisplay {
 
   private final LinkedHashMap<String, TaskDisplay> tasks = new LinkedHashMap<String, TaskDisplay>();
 
-  public void updateTaskStatus(Task<?> tTask) {
+  public synchronized void updateTaskStatus(Task<?> tTask) {
     if (!tasks.containsKey(tTask.getId())) {
       tasks.put(tTask.getId(), new TaskDisplay(tTask));
     }
@@ -374,11 +373,11 @@ public class QueryDisplay {
     this.queryId = queryId;
   }
 
-  private String returnStringOrUnknown(String s) {
+  private static String returnStringOrUnknown(String s) {
     return s == null ? "UNKNOWN" : s;
   }
 
-  public long getQueryStartTime() {
+  public synchronized long getQueryStartTime() {
     return queryStartTime;
   }
 }