[GitHub] [servicecomb-service-center] humingcheng commented on a change in pull request #678: rbac frame pkg should not import un necessary pkg

[GitBox <gi...@apache.org>]

humingcheng commented on a change in pull request #678:
URL: https://github.com/apache/servicecomb-service-center/pull/678#discussion_r471205649



##########
File path: pkg/rbacframe/api_test.go
##########
@@ -49,8 +49,8 @@ func TestMustAuth(t *testing.T) {
 	rbacframe.Add2WhiteAPIList("/test")
 	assert.False(t, rbacframe.MustAuth("/test"))
 	assert.True(t, rbacframe.MustAuth("/auth"))
-	assert.False(t, rbacframe.MustAuth("/version"))
-	assert.False(t, rbacframe.MustAuth("/v4/a/registry/health"))
+	assert.True(t, rbacframe.MustAuth("/version"))

Review comment:
       应该是false




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org