[GitHub] [james-project] mbaechler commented on a change in pull request #264: JAMES-3225 configures CI for builds.apache.org

[GitBox <gi...@apache.org>]

mbaechler commented on a change in pull request #264:
URL: https://github.com/apache/james-project/pull/264#discussion_r571473120



##########
File path: Jenkinsfile
##########
@@ -87,36 +87,37 @@ pipeline {
                 sh 'mvn -U -B -e clean install -DskipTests -T1C'
             }
         }
-

Review comment:
       we should remove this commit from the history

##########
File path: Jenkinsfile
##########
@@ -47,7 +47,7 @@ pipeline {
 
     options {
         // Configure an overall timeout for the build of 4 hours.
-        timeout(time: 4, unit: 'HOURS')

Review comment:
       we should drop this commit (if the current duration is less than 4 hours)

##########
File path: backends-common/elasticsearch/pom.xml
##########
@@ -112,7 +112,7 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
                 <configuration>
-                    <reuseForks>true</reuseForks>

Review comment:
       this commit lack JIRA number

##########
File path: backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java
##########
@@ -118,12 +120,12 @@ private void grantPermissionToTestingUser(Cluster privilegedCluster, String keys
 
     @SuppressWarnings("resource")
     public DockerCassandra() {
-        this("cassandra_3_11_3", AdditionalDockerFileStep.IDENTITY);
+        this("cassandra_3_11_3-"+ UUID.randomUUID().toString(), AdditionalDockerFileStep.IDENTITY);
     }
 
     public DockerCassandra(String imageName, AdditionalDockerFileStep additionalSteps) {
         client = DockerClientFactory.instance().client();
-        boolean doNotDeleteImageAfterUsage = false;
+        boolean doNotDeleteImageAfterUsage = true;

Review comment:
       we should rename the variable to `deleteImageAfterUsage`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org