You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/08 08:29:20 UTC

[GitHub] anirudhacharya commented on issue #13083: [MXNET-345] Hardmax operator

anirudhacharya commented on issue #13083: [MXNET-345] Hardmax operator
URL: https://github.com/apache/incubator-mxnet/pull/13083#issuecomment-445442255
 
 
   It looks good to me for the scope defined. But the following two questions remain - 
    - Why put it in contrib?
    - Should we wait for a full implementation of this operator rather than have this frontend implementation?
   
   Raising these points so that the person merging the PR will consider them while merging the it. Otherwise it LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services