You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2021/03/10 11:41:00 UTC
[jira] [Comment Edited] (SLING-10205) Support converting packages
with custom properties and install hooks
[ https://issues.apache.org/jira/browse/SLING-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298758#comment-17298758 ]
Konrad Windszus edited comment on SLING-10205 at 3/10/21, 11:40 AM:
--------------------------------------------------------------------
[~cziegeler] You once said in the context of https://adapt.to/2020/en/schedule/panel-discussion-aem-as-a-cloud-service.html that install hooks are generally supported, but to me this issue seems to prevent usage of install hooks in immutable packages. For mutable content packages it does not work either (at least on publish) as the underlying service user used in https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/ba075183c374a09b86ca6fa4755a05b26e74866d/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java#L93 does not have the rights to execute install hooks (compare with JCRVLT-427).
was (Author: kwin):
[~cziegeler] You once said in the context of https://adapt.to/2020/en/schedule/panel-discussion-aem-as-a-cloud-service.html that install hooks are generally supported, but to me this issue seems to prevent install hooks anywhere outside mixed/content packages. For mutable content packages it does not work either as the underlying service user used in https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/ba075183c374a09b86ca6fa4755a05b26e74866d/src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java#L93 does not have the rights to execute install hooks (compare with JCRVLT-427).
> Support converting packages with custom properties and install hooks
> --------------------------------------------------------------------
>
> Key: SLING-10205
> URL: https://issues.apache.org/jira/browse/SLING-10205
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Affects Versions: Content-Package to Feature Model Converter 1.0.24
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently only specific properties are being transferred to the converted package: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/acf8c533590b9a081d64ca8e4787bed600f36386/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java#L93. That e.g. prevents usage of [external install hooks|http://jackrabbit.apache.org/filevault/installhooks.html]
> Also no [internal install hooks|http://jackrabbit.apache.org/filevault/installhooks.html] below {{META-INF/vault/hooks}} are being copied to the converted package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)