You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/24 12:31:16 UTC

[GitHub] [spark] grundprinzip commented on a diff in pull request #38345: [SPARK-40879][CONNECT] Support Join UsingColumns in proto

grundprinzip commented on code in PR #38345:
URL: https://github.com/apache/spark/pull/38345#discussion_r1003254127


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -109,6 +109,7 @@ message Join {
   Relation right = 2;
   Expression join_condition = 3;
   JoinType join_type = 4;
+  repeated string using_columns = 5;

Review Comment:
   doc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org