You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/02 18:00:37 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #10233: chore: Deprecating ENABLE_FLASK_COMPRESS

john-bodley opened a new pull request #10233:
URL: https://github.com/apache/incubator-superset/pull/10233


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley merged pull request #10233: chore: Deprecating ENABLE_FLASK_COMPRESS

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #10233:
URL: https://github.com/apache/incubator-superset/pull/10233


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10233: chore: Deprecating ENABLE_FLASK_COMPRESS

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #10233:
URL: https://github.com/apache/incubator-superset/pull/10233#discussion_r449305594



##########
File path: docs/installation.rst
##########
@@ -228,7 +228,7 @@ Note that the development web
 server (`superset run` or `flask run`) is not intended for production use.
 
 If not using gunicorn, you may want to disable the use of flask-compress
-by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py`
+by setting `COMPRESS_REGISTER = False` in your `superset_config.py`

Review comment:
       @bkyryliuk historically `config.py` hasn't enumerated all the various Flask configs but rather only defines those which differ from the defaults.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10233: chore: Deprecating ENABLE_FLASK_COMPRESS

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10233:
URL: https://github.com/apache/incubator-superset/pull/10233#discussion_r449187490



##########
File path: docs/installation.rst
##########
@@ -228,7 +228,7 @@ Note that the development web
 server (`superset run` or `flask run`) is not intended for production use.
 
 If not using gunicorn, you may want to disable the use of flask-compress
-by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py`
+by setting `COMPRESS_REGISTER = False` in your `superset_config.py`

Review comment:
       maybe add COMPRESS_REGISTER to the config.py
   I tend to use the config.py as a documentation for the available configuration options.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10233: chore: Deprecating ENABLE_FLASK_COMPRESS

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10233:
URL: https://github.com/apache/incubator-superset/pull/10233#issuecomment-653368021


   LGTM. 
   
   More generally, I'm wondering if it makes sense to avoid doing too much on the Flask app config and instructing people to use `FLASK_APP_MUTATOR` instead. It gets tricky to surface all the knobs and buttons that the ecosystem offers...
   
   I'm pro having good default, but generally against having the burden of resurfacing / managing all those options...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10233: chore: Deprecating ENABLE_FLASK_COMPRESS

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10233:
URL: https://github.com/apache/incubator-superset/pull/10233#discussion_r449187490



##########
File path: docs/installation.rst
##########
@@ -228,7 +228,7 @@ Note that the development web
 server (`superset run` or `flask run`) is not intended for production use.
 
 If not using gunicorn, you may want to disable the use of flask-compress
-by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py`
+by setting `COMPRESS_REGISTER = False` in your `superset_config.py`

Review comment:
       maybe add COMPRESS_REGISTER to the config.py
   I tend to use the config.py as a documentation for the available configuration options.
   and add the link in the comments: https://github.com/colour-science/flask-compress




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org