You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2011/02/13 04:49:05 UTC
Re: svn commit: r1069588 - in /subversion/trunk:
subversion/tests/cmdline/diff_tests.py
subversion/tests/cmdline/svntest/err.py
subversion/tests/cmdline/svntest/verify.py tools/dev/gen-py-errors.py
hwright@apache.org wrote on Thu, Feb 10, 2011 at 22:04:43 -0000:
> Added: subversion/trunk/tools/dev/gen-py-errors.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dev/gen-py-errors.py?rev=1069588&view=auto
> ==============================================================================
> --- subversion/trunk/tools/dev/gen-py-errors.py (added)
> +++ subversion/trunk/tools/dev/gen-py-errors.py Thu Feb 10 22:04:42 2011
> @@ -0,0 +1,66 @@
> +#!/usr/bin/env python
> +#
> +# gen-py-errors.py: Generate a python module which maps error names to numbers.
> +# (The purpose being easier writing of the python tests.)
> +
> +import sys, os
> +sys.path.append(os.path.join('subversion', 'bindings', 'swig',
> + 'python', 'tests'))
> +
> +
> +import setup_path
This appears to be an unused import.
Re: svn commit: r1069588 - in /subversion/trunk: subversion/tests/cmdline/diff_tests.py
subversion/tests/cmdline/svntest/err.py subversion/tests/cmdline/svntest/verify.py
tools/dev/gen-py-errors.py
Posted by Hyrum K Wright <hy...@hyrumwright.org>.
On Sun, Feb 13, 2011 at 3:49 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> hwright@apache.org wrote on Thu, Feb 10, 2011 at 22:04:43 -0000:
>> Added: subversion/trunk/tools/dev/gen-py-errors.py
>> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dev/gen-py-errors.py?rev=1069588&view=auto
>> ==============================================================================
>> --- subversion/trunk/tools/dev/gen-py-errors.py (added)
>> +++ subversion/trunk/tools/dev/gen-py-errors.py Thu Feb 10 22:04:42 2011
>> @@ -0,0 +1,66 @@
>> +#!/usr/bin/env python
>> +#
>> +# gen-py-errors.py: Generate a python module which maps error names to numbers.
>> +# (The purpose being easier writing of the python tests.)
>> +
>> +import sys, os
>> +sys.path.append(os.path.join('subversion', 'bindings', 'swig',
>> + 'python', 'tests'))
>> +
>> +
>> +import setup_path
>
> This appears to be an unused import.
It appears as such, but actually isn't. setup_path.py does some
fudging with global state to ensure the development bindings are
properly loaded (instead of any installed bindings). The swig python
tests also use it in such a manner.
-Hyrum
Re: svn commit: r1069588 - in /subversion/trunk: subversion/tests/cmdline/diff_tests.py
subversion/tests/cmdline/svntest/err.py subversion/tests/cmdline/svntest/verify.py
tools/dev/gen-py-errors.py
Posted by Hyrum K Wright <hy...@hyrumwright.org>.
On Sun, Feb 13, 2011 at 3:49 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> hwright@apache.org wrote on Thu, Feb 10, 2011 at 22:04:43 -0000:
>> Added: subversion/trunk/tools/dev/gen-py-errors.py
>> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dev/gen-py-errors.py?rev=1069588&view=auto
>> ==============================================================================
>> --- subversion/trunk/tools/dev/gen-py-errors.py (added)
>> +++ subversion/trunk/tools/dev/gen-py-errors.py Thu Feb 10 22:04:42 2011
>> @@ -0,0 +1,66 @@
>> +#!/usr/bin/env python
>> +#
>> +# gen-py-errors.py: Generate a python module which maps error names to numbers.
>> +# (The purpose being easier writing of the python tests.)
>> +
>> +import sys, os
>> +sys.path.append(os.path.join('subversion', 'bindings', 'swig',
>> + 'python', 'tests'))
>> +
>> +
>> +import setup_path
>
> This appears to be an unused import.
It appears as such, but actually isn't. setup_path.py does some
fudging with global state to ensure the development bindings are
properly loaded (instead of any installed bindings). The swig python
tests also use it in such a manner.
-Hyrum