[GitHub] [accumulo] jzgithub1 commented on issue #1112: Fixes #1052 - Review DistributedCache usage - Changed how token files and property files get cached

[GitBox <gi...@apache.org>]

jzgithub1 commented on issue #1112: Fixes #1052 - Review DistributedCache usage - Changed how token files and property files get cached
URL: https://github.com/apache/accumulo/pull/1112#issuecomment-498375633
 
 
   I am comfortable with the changes to RangePartitioner @ctubbsii.  I tested the hdfs caching mechanism using the "fragment" after a hash tag in the URI when adding to hdfs cache.  I verified proper caching in the debugger of the Intellij while stepping through the BulkIngestExample.java class during execution.  The main function of the BulkIngestExample class calls RangePartitioner.setSplitFile which calls job.addCacheFile the URI with the fragment. The during the actual MR job execution ,  in RangePartitioner.getCutPoints ,  the splits.txt file is access by the fragement URI called: org.apache.accumulo.hadoop.mapreduce.partition.RangePartitioner.cutFile  in the present working directory of the script or project.  This was my last concern about the code changes and I am confident it is ready for merging.   
   
   Let me know if there is anything that you feel I have missed here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services