You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/18 10:53:15 UTC

[GitHub] [pulsar] asafm opened a new pull request, #18974: [fix][doc] Ammend PIP proposal around discussions

asafm opened a new pull request, #18974:
URL: https://github.com/apache/pulsar/pull/18974

   
   
   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   ### Motivation
   
   Sometimes PIP discussion happens concurrently in the mailing list DISCUSS thread and the PIP GitHub issue using comments. This creates confusion. 
   
   ### Modifications
   
   Modified the PIP process file to explicitly state PIP discussion should be in the mailing list and not in the GitHub issue. This was after a [discussion](https://lists.apache.org/thread/61byrwwqq96f7f55ft1xdjc78g7mntx0) on the mailing list.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   ### Does this pull request potentially affect one of the following parts:
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #18974: [fix][doc] Ammend PIP proposal around discussions

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #18974:
URL: https://github.com/apache/pulsar/pull/18974#issuecomment-1356772587

   @asafm Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] asafm commented on pull request #18974: [fix][doc] Ammend PIP proposal around discussions

Posted by GitBox <gi...@apache.org>.
asafm commented on PR #18974:
URL: https://github.com/apache/pulsar/pull/18974#issuecomment-1356772566

   Not sure this counts as doc since this is a Wiki page change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] asafm commented on pull request #18974: [fix][doc] Ammend PIP proposal around discussions

Posted by GitBox <gi...@apache.org>.
asafm commented on PR #18974:
URL: https://github.com/apache/pulsar/pull/18974#issuecomment-1357279048

   Thanks @codelipenghui 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #18974: [fix][doc] Ammend PIP proposal around discussions

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #18974:
URL: https://github.com/apache/pulsar/pull/18974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org