You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/11/21 05:21:16 UTC

[kudu-CR] log: refactor close and replace last segment

Hello Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14767

to review the following change.


Change subject: log: refactor close and replace last segment
......................................................................

log: refactor close and replace last segment

Log::Close and SegmentAllocator::RollOver both tried to do the same thing,
except Log::Close didn't actually need to replace the last segment, nor did
it need to close the current segment with state_lock_ held.

I also snuck in a small fix to LogIndex::IndexChunk::Open's use of
ftruncate, and a visibility fix to a SegmentAllocator member.

Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_index.cc
3 files changed, 56 insertions(+), 39 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/14767/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Gerrit-Change-Number: 14767
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] log: refactor close and replace last segment

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14767 )

Change subject: log: refactor close and replace last segment
......................................................................

log: refactor close and replace last segment

Log::Close and SegmentAllocator::RollOver both tried to do the same thing,
except Log::Close didn't actually need to replace the last segment, nor did
it need to close the current segment with state_lock_ held.

I also snuck in a small fix to LogIndex::IndexChunk::Open's use of
ftruncate, and a visibility fix to a SegmentAllocator member.

Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Reviewed-on: http://gerrit.cloudera.org:8080/14767
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_index.cc
3 files changed, 56 insertions(+), 39 deletions(-)

Approvals:
  Adar Dembo: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Gerrit-Change-Number: 14767
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] log: refactor close and replace last segment

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14767 )

Change subject: log: refactor close and replace last segment
......................................................................


Patch Set 1: Verified+1

Overriding Jenkins, unrelated Raft test failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/14767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Gerrit-Change-Number: 14767
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Nov 2019 05:44:03 +0000
Gerrit-HasComments: No

[kudu-CR] log: refactor close and replace last segment

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14767 )

Change subject: log: refactor close and replace last segment
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Gerrit-Change-Number: 14767
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Nov 2019 05:57:22 +0000
Gerrit-HasComments: No

[kudu-CR] log: refactor close and replace last segment

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.

Change subject: log: refactor close and replace last segment
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Gerrit-Change-Number: 14767
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)